Skip to content
Permalink
Browse files
2009-10-28 Joanmarie Diggs <joanmarie.diggs@gmail.com>
        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=25897
        [Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries

        Remove the extraneous object of ROLE_PANEL.

        * accessibility/gtk/AccessibilityObjectAtk.cpp:
        (AccessibilityObject::accessibilityPlatformIncludesObject):

Canonical link: https://commits.webkit.org/41680@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
eseidel committed Oct 28, 2009
1 parent 4b0d06d commit 84a09c35592058fb6f2cb6218e11d2b24fb782e6
Showing with 22 additions and 5 deletions.
  1. +12 −0 WebCore/ChangeLog
  2. +10 −5 WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp
@@ -1,3 +1,15 @@
2009-10-28 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25897
[Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries

Remove the extraneous object of ROLE_PANEL.

* accessibility/gtk/AccessibilityObjectAtk.cpp:
(AccessibilityObject::accessibilityPlatformIncludesObject):

2009-10-28 Jonathan Dixon <joth@chromium.org>

Reviewed by Eric Seidel.
@@ -34,13 +34,18 @@ bool AccessibilityObject::accessibilityIgnoreAttachment() const

AccessibilityObjectPlatformInclusion AccessibilityObject::accessibilityPlatformIncludesObject() const
{
AccessibilityObject* parent = parentObject();
if (!parent)
return DefaultBehavior;

// When a list item is made up entirely of children (e.g. paragraphs)
// the list item gets ignored. We need it.
if (isGroup()) {
AccessibilityObject* parent = parentObject();
if (parent && parent->isList())
return IncludeObject;
}
if (isGroup() && parent->isList())
return IncludeObject;

// Entries and password fields have extraneous children which we want to ignore.
if (parent->isPasswordField() || parent->isTextControl())
return IgnoreObject;

return DefaultBehavior;
}

0 comments on commit 84a09c3

Please sign in to comment.