Skip to content
Permalink
Browse files
Web Inspector: Labels in the computed panel are shifted when a filter…
… is applieds

https://bugs.webkit.org/show_bug.cgi?id=148250

Reviewed by Timothy Hatcher.

Added to the selectors for filtering to ensure they only apply to the rules panel.

* UserInterface/Views/RulesStyleDetailsPanel.css:
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label):
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label:not(.filter-section-non-matching) ~ .label):
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label.filter-matching-label):
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label:not(.filter-section-non-matching) + .label.filter-matching-label:not(.filter-section-non-matching)):
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .new-rule):
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .style-declaration-section:not(.filter-section-non-matching) ~ .label:not(.filter-section-non-matching)):
(@media (-webkit-min-device-pixel-ratio: 2)):
(.sidebar > .panel.details.css-style > .content.filter-in-progress .label): Deleted.
(.sidebar > .panel.details.css-style > .content.filter-in-progress .label:not(.filter-section-non-matching) ~ .label): Deleted.
(.sidebar > .panel.details.css-style > .content.filter-in-progress .label.filter-matching-label): Deleted.
(.sidebar > .panel.details.css-style > .content.filter-in-progress .label:not(.filter-section-non-matching) + .label.filter-matching-label:not(.filter-section-non-matching)): Deleted.
(.sidebar > .panel.details.css-style > .content.filter-in-progress .new-rule): Deleted.
(.sidebar > .panel.details.css-style > .content.filter-in-progress .style-declaration-section:not(.filter-section-non-matching) ~ .label:not(.filter-section-non-matching)): Deleted.


Canonical link: https://commits.webkit.org/166383@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@188732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
dcrousso committed Aug 21, 2015
1 parent 0402c4c commit 87383bbf386bc05d599463d7f13c932d880e537e
Showing 2 changed files with 31 additions and 7 deletions.
@@ -1,3 +1,27 @@
2015-08-20 Devin Rousso <drousso@apple.com>

Web Inspector: Labels in the computed panel are shifted when a filter is applieds
https://bugs.webkit.org/show_bug.cgi?id=148250

Reviewed by Timothy Hatcher.

Added to the selectors for filtering to ensure they only apply to the rules panel.

* UserInterface/Views/RulesStyleDetailsPanel.css:
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label):
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label:not(.filter-section-non-matching) ~ .label):
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label.filter-matching-label):
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label:not(.filter-section-non-matching) + .label.filter-matching-label:not(.filter-section-non-matching)):
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .new-rule):
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .style-declaration-section:not(.filter-section-non-matching) ~ .label:not(.filter-section-non-matching)):
(@media (-webkit-min-device-pixel-ratio: 2)):
(.sidebar > .panel.details.css-style > .content.filter-in-progress .label): Deleted.
(.sidebar > .panel.details.css-style > .content.filter-in-progress .label:not(.filter-section-non-matching) ~ .label): Deleted.
(.sidebar > .panel.details.css-style > .content.filter-in-progress .label.filter-matching-label): Deleted.
(.sidebar > .panel.details.css-style > .content.filter-in-progress .label:not(.filter-section-non-matching) + .label.filter-matching-label:not(.filter-section-non-matching)): Deleted.
(.sidebar > .panel.details.css-style > .content.filter-in-progress .new-rule): Deleted.
(.sidebar > .panel.details.css-style > .content.filter-in-progress .style-declaration-section:not(.filter-section-non-matching) ~ .label:not(.filter-section-non-matching)): Deleted.

2015-08-20 Devin Rousso <drousso@apple.com>

Web Inspector: Fix "attempted to assign to readonly property" in Visual editor links
@@ -59,28 +59,28 @@
margin-top: 8px;
}

.sidebar > .panel.details.css-style > .content.filter-in-progress .label {
.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label {
padding-top: 15px;
}

.sidebar > .panel.details.css-style > .content.filter-in-progress .label:not(.filter-section-non-matching) ~ .label {
.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label:not(.filter-section-non-matching) ~ .label {
padding-top: 0;
}

.sidebar > .panel.details.css-style > .content.filter-in-progress .label.filter-matching-label {
.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label.filter-matching-label {
padding-bottom: 5px;
border-bottom: 1px solid hsla(0, 0%, 0%, 0.3);
}

.sidebar > .panel.details.css-style > .content.filter-in-progress .label:not(.filter-section-non-matching) + .label.filter-matching-label:not(.filter-section-non-matching) {
.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label:not(.filter-section-non-matching) + .label.filter-matching-label:not(.filter-section-non-matching) {
padding-top: 0;
}

.sidebar > .panel.details.css-style > .content.filter-in-progress .new-rule {
.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .new-rule {
display: none;
}

.sidebar > .panel.details.css-style > .content.filter-in-progress .style-declaration-section:not(.filter-section-non-matching) ~ .label:not(.filter-section-non-matching) {
.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .style-declaration-section:not(.filter-section-non-matching) ~ .label:not(.filter-section-non-matching) {
padding-top: 15px;
}

@@ -139,7 +139,7 @@

@media (-webkit-min-device-pixel-ratio: 2) {
.sidebar > .panel.details.css-style > .content:not(.filter-in-progress) > .rules > .new-rule + .label,
.sidebar > .panel.details.css-style > .content.filter-in-progress .label.filter-matching-label,
.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label.filter-matching-label,
.no-filter-results-message {
border-width: 0.5px !important;
}

0 comments on commit 87383bb

Please sign in to comment.