Skip to content
Permalink
Browse files
Layout Test fast/dom/HTMLMeterElement/meter-element-crash.html is fai…
…ling

https://bugs.webkit.org/show_bug.cgi?id=88131

Reviewed by Tony Chang.

This test was calling setTimeout(..., 0) in a <script> block before the end of the document.
The timeout sometimes fired before parsing the rest of the document and sometimes after,
depending on when the parser yielded. This moves the <script> block to the end of the document
so it always runs after parsing the rest of the test, which is the more common and expected
behavior.

* fast/dom/HTMLMeterElement/meter-element-crash.html:

Canonical link: https://commits.webkit.org/130243@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
jamesr committed Mar 8, 2013
1 parent ca68f87 commit 87f7197a2c2cfccd338809dfb41f82289ecde590
Showing 2 changed files with 23 additions and 8 deletions.
@@ -1,3 +1,18 @@
2013-03-08 James Robinson <jamesr@chromium.org>

Layout Test fast/dom/HTMLMeterElement/meter-element-crash.html is failing
https://bugs.webkit.org/show_bug.cgi?id=88131

Reviewed by Tony Chang.

This test was calling setTimeout(..., 0) in a <script> block before the end of the document.
The timeout sometimes fired before parsing the rest of the document and sometimes after,
depending on when the parser yielded. This moves the <script> block to the end of the document
so it always runs after parsing the rest of the test, which is the more common and expected
behavior.

* fast/dom/HTMLMeterElement/meter-element-crash.html:

2013-03-07 Geoffrey Garen <ggaren@apple.com>

Added a regression test for raw parsing speed
@@ -4,6 +4,14 @@
-webkit-appearance: none;
}
</style>
<span id="test">
<script>
document.body.offsetTop;
</script>
<input type="text">
<meter>
</meter>
</span>
<script>
if (window.testRunner) {
testRunner.dumpAsText();
@@ -16,11 +24,3 @@
testRunner.notifyDone();
}, 0);
</script>
<span id="test">
<script>
document.body.offsetTop;
</script>
<input type="text">
<meter>
</meter>
</span>

0 comments on commit 87f7197

Please sign in to comment.