Skip to content
Permalink
Browse files
Unreviewed, rolling out r228103.
This caused multiple tests to crash.

Reverted changeset:

"Use downcast in createLinkPreloadResourceClient"
https://bugs.webkit.org/show_bug.cgi?id=182488
https://trac.webkit.org/changeset/228103

Canonical link: https://commits.webkit.org/198298@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@228117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
huskyroll committed Feb 5, 2018
1 parent 0a946de commit 881f986cfb3476ecc4bc2d8ff29b0deca36469ed
Showing 2 changed files with 17 additions and 5 deletions.
@@ -1,3 +1,15 @@
2018-02-05 Matt Lewis <jlewis3@apple.com>

Unreviewed, rolling out r228103.

This caused multiple tests to crash.

Reverted changeset:

"Use downcast in createLinkPreloadResourceClient"
https://bugs.webkit.org/show_bug.cgi?id=182488
https://trac.webkit.org/changeset/228103

2018-02-05 Eric Carlson <eric.carlson@apple.com>

[iOS] VideoFullscreenInterfaceAVKit should not ignore errors
@@ -139,13 +139,13 @@ static std::unique_ptr<LinkPreloadResourceClient> createLinkPreloadResourceClien
{
switch (resource.type()) {
case CachedResource::ImageResource:
return LinkPreloadImageResourceClient::create(loader, downcast<CachedImage>(resource));
return LinkPreloadImageResourceClient::create(loader, static_cast<CachedImage&>(resource));
case CachedResource::Script:
return LinkPreloadScriptResourceClient::create(loader, downcast<CachedScript>(resource));
return LinkPreloadScriptResourceClient::create(loader, static_cast<CachedScript&>(resource));
case CachedResource::CSSStyleSheet:
return LinkPreloadStyleResourceClient::create(loader, downcast<CachedCSSStyleSheet>(resource));
return LinkPreloadStyleResourceClient::create(loader, static_cast<CachedCSSStyleSheet&>(resource));
case CachedResource::FontResource:
return LinkPreloadFontResourceClient::create(loader, downcast<CachedFont>(resource));
return LinkPreloadFontResourceClient::create(loader, static_cast<CachedFont&>(resource));
case CachedResource::MediaResource:
if (!RuntimeEnabledFeatures::sharedFeatures().mediaPreloadingEnabled())
ASSERT_NOT_REACHED();
@@ -154,7 +154,7 @@ static std::unique_ptr<LinkPreloadResourceClient> createLinkPreloadResourceClien
case CachedResource::TextTrackResource:
#endif
case CachedResource::RawResource:
return LinkPreloadRawResourceClient::create(loader, downcast<CachedRawResource>(resource));
return LinkPreloadRawResourceClient::create(loader, static_cast<CachedRawResource&>(resource));
case CachedResource::MainResource:
case CachedResource::Icon:
#if ENABLE(SVG_FONTS)

0 comments on commit 881f986

Please sign in to comment.