Skip to content
Permalink
Browse files
RealtimeOutgoingVideoSourceCocoa pixelBufferPool should use video range
https://bugs.webkit.org/show_bug.cgi?id=240463
rdar://problem/93354226

Patch by Youenn Fablet <youennf@gmail.com> on 2022-05-23
Reviewed by Eric Carlson.

We switched to using a pixel conformer that was using preferredPixelFormat to using libyuv routine.
Update the pixel buffer pool to use kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange to be compliant with libyuv routines.

* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm:
(WebCore::RealtimeOutgoingVideoSourceCocoa::pixelBufferPool):

Canonical link: https://commits.webkit.org/250861@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
youennf authored and webkit-commit-queue committed May 23, 2022
1 parent aa4848a commit 897e10ed1a9676de3c9dc5e8df19b059a5f17b1d
Showing 2 changed files with 1 addition and 5 deletions.
@@ -3610,10 +3610,6 @@ webkit.org/b/240148 fast/images/exif-orientation-background-image-repeat.html [

webkit.org/b/240167 [ Release ] fast/css-custom-paint/animate-repaint.html [ Pass Failure ]

webkit.org/b/240348 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-videoDetectorTest.html [ Failure ]

webkit.org/b/240463 imported/w3c/web-platform-tests/webrtc/RTCRtpSender-replaceTrack.https.html [ Failure ]

webkit.org/b/240489 imported/w3c/web-platform-tests/html/browsers/browsing-the-web/unloading-documents/004.html [ Slow ]

# Correction to guard in Platform file removing iOS - Skip tests
@@ -78,7 +78,7 @@ static inline unsigned rotationToAngle(webrtc::VideoRotation rotation)
CVPixelBufferPoolRef RealtimeOutgoingVideoSourceCocoa::pixelBufferPool(size_t width, size_t height)
{
if (!m_pixelBufferPool || m_pixelBufferPoolWidth != width || m_pixelBufferPoolHeight != height) {
auto result = createInMemoryCVPixelBufferPool(width, height, preferedPixelBufferFormat());
auto result = createInMemoryCVPixelBufferPool(width, height, kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange);
if (!result) {
RELEASE_LOG_ERROR(WebRTC, "RealtimeOutgoingVideoSourceCocoa failed creating buffer pool with error %d", result.error());
return nullptr;

0 comments on commit 897e10e

Please sign in to comment.