Please sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
SVGAnimatedListPropertyTearOff::synchronizeWrappersIfNeeded() should …
…do nothing if the property is not animating https://bugs.webkit.org/show_bug.cgi?id=181316 <rdar://problem/36147545> Patch by Said Abou-Hallawa <firstname.lastname@example.org> on 2018-01-05 Reviewed by Simon Fraser. This is a speculative change to fix a crash which appeared after r226065. The crash is very intermittent and sometimes very hard to reproduce. The basic code analysis did not show how this crash can even happen. * svg/SVGAnimatedTypeAnimator.h: (WebCore::SVGAnimatedTypeAnimator::resetFromBaseValues): For SVG property with two values, e.g. <SVGAngleValue, SVGMarkerOrientType>, we need to detach the wrappers of the animated property if the animated values are going to change. This is similar to what we did in resetFromBaseValue(). * svg/properties/SVGAnimatedListPropertyTearOff.h: (WebCore::SVGAnimatedListPropertyTearOff::synchronizeWrappersIfNeeded): Canonical link: https://commits.webkit.org/197174@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@226457 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing with 32 additions and 3 deletions.