Skip to content
Permalink
Browse files
[GTK] Remove a focus ring on anchor node when focused by mouse.
https://bugs.webkit.org/show_bug.cgi?id=136121

Reviewed by Michael Catanzaro.

Source/WebCore:

Safari, Chrome and FF don't show a focus ring, the dotted rectangle on anchor node
for mouse clicking. I think the behavior is reasonable and looks better.
No reason for gtk & efl ports to keep the focus on anchor node. Of course, this change should not
affect the focus ring for tab navigation.

No new tests since an existing test can cover this.
Tests: fast/events/click-focus-anchor.html

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::isMouseFocusable):

LayoutTests:

Removed gtk and efl specific results for the test.

* platform/efl/fast/events/click-focus-anchor-expected.txt: Removed.
* platform/gtk/fast/events/click-focus-anchor-expected.txt: Removed.


Canonical link: https://commits.webkit.org/171413@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@195447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
shivamidow committed Jan 22, 2016
1 parent 687bbd5 commit 8d5c24992685c2334c7aa3427727682a342b8aa1
Showing 5 changed files with 30 additions and 25 deletions.
@@ -1,3 +1,15 @@
2016-01-22 ChangSeok Oh <changseok.oh@collabora.com>

[GTK] Remove a focus ring on anchor node when focused by mouse.
https://bugs.webkit.org/show_bug.cgi?id=136121

Reviewed by Michael Catanzaro.

Removed gtk and efl specific results for the test.

* platform/efl/fast/events/click-focus-anchor-expected.txt: Removed.
* platform/gtk/fast/events/click-focus-anchor-expected.txt: Removed.

2016-01-21 Simon Fraser <simon.fraser@apple.com>

REGRESSION (r168244): Content in horizontal-bt page is offset such that only the end is viewable and there is a white gap at the top

This file was deleted.

This file was deleted.

@@ -1,3 +1,21 @@
2016-01-22 ChangSeok Oh <changseok.oh@collabora.com>

[GTK] Remove a focus ring on anchor node when focused by mouse.
https://bugs.webkit.org/show_bug.cgi?id=136121

Reviewed by Michael Catanzaro.

Safari, Chrome and FF don't show a focus ring, the dotted rectangle on anchor node
for mouse clicking. I think the behavior is reasonable and looks better.
No reason for gtk & efl ports to keep the focus on anchor node. Of course, this change should not
affect the focus ring for tab navigation.

No new tests since an existing test can cover this.
Tests: fast/events/click-focus-anchor.html

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::isMouseFocusable):

2016-01-21 Simon Fraser <simon.fraser@apple.com>

REGRESSION (r168244): Content in horizontal-bt page is offset such that only the end is viewable and there is a white gap at the top
@@ -95,12 +95,9 @@ bool HTMLAnchorElement::supportsFocus() const

bool HTMLAnchorElement::isMouseFocusable() const
{
#if !(PLATFORM(EFL) || PLATFORM(GTK))
// Only allow links with tabIndex or contentEditable to be mouse focusable.
// This is our rule for the Mac platform; on many other platforms we focus any link you click on.
if (isLink())
return HTMLElement::supportsFocus();
#endif

return HTMLElement::isMouseFocusable();
}

0 comments on commit 8d5c249

Please sign in to comment.