Skip to content
Permalink
Browse files
Unreviewed, rolling out r223271.
This change introduced LayoutTest failures on WK1.

Reverted changeset:

"Use asynchronous ResourceHandleClient calls for WebKit1"
https://bugs.webkit.org/show_bug.cgi?id=160677
https://trac.webkit.org/changeset/223271

Canonical link: https://commits.webkit.org/194553@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@223408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
ryanhaddad committed Oct 16, 2017
1 parent ac5b0a3 commit 8d7ac958ea60171def5e515eb66fdb260d153c63
Showing 53 changed files with 1,181 additions and 563 deletions.
@@ -1,3 +1,15 @@
2017-10-16 Ryan Haddad <ryanhaddad@apple.com>

Unreviewed, rolling out r223271.

This change introduced LayoutTest failures on WK1.

Reverted changeset:

"Use asynchronous ResourceHandleClient calls for WebKit1"
https://bugs.webkit.org/show_bug.cgi?id=160677
https://trac.webkit.org/changeset/223271

2017-10-16 Per Arne Vollan <pvollan@apple.com>

Mark animations/play-state-in-shorthand.html as flaky on Windows.
@@ -39,9 +39,6 @@ http/tests/preload/viewport [ Skip ]

# window.showModalDialog is only tested in DumpRenderTree on Mac.
editing/execCommand/show-modal-dialog-during-execCommand.html [ Skip ]
http/tests/security/cross-origin-modal-dialog-base.html [ Skip ]
fast/events/scroll-event-during-modal-dialog.html [ Skip ]
fast/harness/show-modal-dialog.html [ Skip ]

fast/shadow-dom/touch-event-on-text-assigned-to-slot.html [ Skip ]

@@ -441,11 +438,6 @@ webkit.org/b/169565 imported/w3c/web-platform-tests/cors/status-preflight.htm [
webkit.org/b/169565 imported/w3c/web-platform-tests/cors/status-async.htm [ Failure ]
webkit.org/b/169565 imported/w3c/web-platform-tests/cors/304.htm [ Failure ]

# These tests used to have deterministic load delegate callback order before webkit.org/b/160677
http/tests/svg/svg-use-external.html [ Pass Failure ]
http/tests/loading/text-content-type-with-binary-extension.html [ Pass Failure ]
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-iframe-in-main-frame.html [ Pass Failure ]

# Tests that are flakey due to unhandled promise rejection error messages
webkit.org/b/171094 imported/w3c/web-platform-tests/streams/readable-streams/tee.html [ Pass Failure ]
webkit.org/b/171094 streams/brand-checks.html [ Pass Failure ]
@@ -784,7 +776,6 @@ webkit.org/b/139840 fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html

webkit.org/b/140043 js/dom/Promise.html [ Pass Failure ]

webkit.org/b/134550 http/tests/cache/iframe-304-crash.html [ Failure Pass ]
webkit.org/b/141267 http/tests/misc/detached-frame-console.html [ Pass Failure ]

# Aborting application cache abort tests are intrinsically flaky.
@@ -1635,6 +1635,8 @@ webkit.org/b/133869 media/video-seek-after-end.html [ Failure Pass ]
# Crash is webkit.org/b/176802
webkit.org/b/36642 fast/replaced/border-radius-clip.html [ Failure Pass Crash ]

webkit.org/b/134550 http/tests/cache/iframe-304-crash.html [ Failure Pass ]

webkit.org/b/134573 media/track/audio-track.html [ Failure Timeout Pass ]
webkit.org/b/134576 media/track/audio/audio-track-mkv-vorbis-language.html [ Failure Timeout Pass ]
webkit.org/b/134576 media/track/track-cue-rendering.html [ Failure Timeout Pass ]
@@ -446,6 +446,7 @@ http/tests/websocket/tests/hybi/invalid-subprotocol-characters.html
http/tests/xmlhttprequest/cross-origin-authorization-with-embedder.html

# HTTP tests that are flaky:
http/tests/cache/iframe-304-crash.html [ Failure Pass ]
http/tests/navigation/forward-and-cancel.html [ Failure Pass ]
http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml [ Failure Pass ]
http/tests/webarchive/cross-origin-stylesheet-crash.html [ Failure Pass ]
@@ -297,6 +297,8 @@ webkit.org/b/125996 accessibility/mac/search-when-element-starts-in-table.html [

webkit.org/b/162999 accessibility/mac/wk1-set-selected-text-marker-range-input-element.html [ Skip ]

webkit.org/b/134550 http/tests/cache/iframe-304-crash.html [ Pass Failure ]

# testRunner.setUseDeferredFrameLoading is not implemented.
webkit.org/b/93980 http/tests/appcache/load-from-appcache-defer-resume-crash.html [ Skip ]

@@ -264,6 +264,7 @@ http/tests/loading/cross-origin-XHR-willLoadRequest.html
# WebKit2 needs showModalDialog
fast/events/scroll-event-during-modal-dialog.html
fast/harness/show-modal-dialog.html
http/tests/security/cross-origin-modal-dialog-base.html [ Skip ]

# WebKit2 needs to support synchronous creation of about:blank/data:url frames
fast/dom/HTMLDocument/hasFocus.html
@@ -67,19 +67,12 @@
setTimeout("testRunner.notifyDone()", 0);
}
}

function makeImage() {
var image = document.createElement("img");
image.onerror=nextBlockedPortTest;
image.src="http://255.255.255.255:1/test.jpg";
image.id="testIMG";
document.body.appendChild(image);
}
</script>
<body onload="makeImage()">
<body>
<p>This test attempts to change the src of an IMG tag to all black listed ports to confirm that WebKit returns the
correct error for them - blocked instead of cannot find. It also tries the FTP ports for exemptions. Due to the
nature of this test, the results can only be processed automatically via DumpRenderTree
</p>
<img id="testIMG" src="http://255.255.255.255:1/test.jpg" onError="nextBlockedPortTest();"></img>
</body>
</html>
@@ -4,15 +4,6 @@
SVG documents included by reference should be transparent. Any white visible in the green box is a failure.
-->
<head>
<script>
if (window.testRunner)
testRunner.waitUntilDone();
var elementsLoaded = 0;
function loaded() {
if (window.testRunner && ++elementsLoaded == 5)
testRunner.notifyDone();
}
</script>
<style type='text/css'>
* {
margin: 0px;
@@ -30,11 +21,11 @@
</head>
<body>
<div>
<object onload="loaded()" type='image/svg+xml' width='50' height='50' data='data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIj8+Cjxzdmcgd2lkdGg9IjUwIiBoZWlnaHQ9IjUwIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciLz4='></object>
<embed onload="loaded()" width='50' height='50' src='data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIj8+Cjxzdmcgd2lkdGg9IjUwIiBoZWlnaHQ9IjUwIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciLz4='></embed>
<iframe onload="loaded()" width='100' height='100' src='data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIj8+Cjxzdmcgd2lkdGg9IjUwIiBoZWlnaHQ9IjUwIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciLz4='></iframe>
<object onload="loaded()" type='text/xml' width='50' height='50' data='data:text/xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIj8+Cjxzdmcgd2lkdGg9IjUwIiBoZWlnaHQ9IjUwIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciLz4='></object>
<object onload="loaded()" type='application/xml' width='50' height='50' data='data:application/xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIj8+Cjxzdmcgd2lkdGg9IjUwIiBoZWlnaHQ9IjUwIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciLz4='></object-->
<object type='image/svg+xml' width='50' height='50' data='data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIj8+Cjxzdmcgd2lkdGg9IjUwIiBoZWlnaHQ9IjUwIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciLz4='></object>
<embed width='50' height='50' src='data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIj8+Cjxzdmcgd2lkdGg9IjUwIiBoZWlnaHQ9IjUwIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciLz4='></embed>
<iframe width='100' height='100' src='data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIj8+Cjxzdmcgd2lkdGg9IjUwIiBoZWlnaHQ9IjUwIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciLz4='></iframe>
<object type='text/xml' width='50' height='50' data='data:text/xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIj8+Cjxzdmcgd2lkdGg9IjUwIiBoZWlnaHQ9IjUwIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciLz4='></object>
<object type='application/xml' width='50' height='50' data='data:application/xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIj8+Cjxzdmcgd2lkdGg9IjUwIiBoZWlnaHQ9IjUwIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciLz4='></object-->
</div>
</body>
</html>
@@ -1,3 +1,15 @@
2017-10-16 Ryan Haddad <ryanhaddad@apple.com>

Unreviewed, rolling out r223271.

This change introduced LayoutTest failures on WK1.

Reverted changeset:

"Use asynchronous ResourceHandleClient calls for WebKit1"
https://bugs.webkit.org/show_bug.cgi?id=160677
https://trac.webkit.org/changeset/223271

2017-10-16 Alejandro G. Castro <alex@igalia.com>

Make RealtimeIncomingVideoSources and RealtimeOutgoingVideoSources port agnostic
@@ -60,11 +60,11 @@ list(APPEND WebCore_SOURCES
platform/network/cf/ResourceErrorCF.cpp
platform/network/cf/ResourceHandleCFNet.cpp
platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp
platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp
platform/network/cf/ResourceRequestCFNet.cpp
platform/network/cf/ResourceResponseCFNet.cpp
platform/network/cf/SocketStreamHandleImplCFNet.cpp
platform/network/cf/SynchronousLoaderClientCFNet.cpp
platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp
)

if (${USE_DIRECT2D})
@@ -562,6 +562,7 @@ list(APPEND WebCore_SOURCES
platform/network/mac/ResourceHandleMac.mm
platform/network/mac/SynchronousLoaderClient.mm
platform/network/mac/UTIUtilities.mm
platform/network/mac/WebCoreResourceHandleAsDelegate.mm
platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm
platform/network/mac/WebCoreURLResponse.mm

@@ -1091,6 +1091,8 @@
26F9A83918A046AC00AEB88A /* ViewportConfiguration.h in Headers */ = {isa = PBXBuildFile; fileRef = 26F9A83718A046AC00AEB88A /* ViewportConfiguration.h */; settings = {ATTRIBUTES = (Private, ); }; };
26FAE4CC1852E3A5004C8C46 /* ResourceHandleCFURLConnectionDelegate.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 26FAE4C81852E3A5004C8C46 /* ResourceHandleCFURLConnectionDelegate.cpp */; };
26FAE4CD1852E3A5004C8C46 /* ResourceHandleCFURLConnectionDelegate.h in Headers */ = {isa = PBXBuildFile; fileRef = 26FAE4C91852E3A5004C8C46 /* ResourceHandleCFURLConnectionDelegate.h */; };
26FAE4CE1852E3A5004C8C46 /* SynchronousResourceHandleCFURLConnectionDelegate.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 26FAE4CA1852E3A5004C8C46 /* SynchronousResourceHandleCFURLConnectionDelegate.cpp */; };
26FAE4CF1852E3A5004C8C46 /* SynchronousResourceHandleCFURLConnectionDelegate.h in Headers */ = {isa = PBXBuildFile; fileRef = 26FAE4CB1852E3A5004C8C46 /* SynchronousResourceHandleCFURLConnectionDelegate.h */; };
2914E3071CAB5A440049966F /* AccessibilityAttachment.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2914E3051CAB5A440049966F /* AccessibilityAttachment.cpp */; };
2914E3081CAB5A440049966F /* AccessibilityAttachment.h in Headers */ = {isa = PBXBuildFile; fileRef = 2914E3061CAB5A440049966F /* AccessibilityAttachment.h */; };
2917B5611473496C0052C9D0 /* LayerFlushScheduler.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2917B55E1473496C0052C9D0 /* LayerFlushScheduler.cpp */; };
@@ -6703,6 +6705,8 @@
E17B491616A9B094001C8839 /* TransitionEvent.h in Headers */ = {isa = PBXBuildFile; fileRef = E17B491416A9B093001C8839 /* TransitionEvent.h */; };
E17B492116A9B8FF001C8839 /* JSTransitionEvent.h in Headers */ = {isa = PBXBuildFile; fileRef = E17B491F16A9B8FF001C8839 /* JSTransitionEvent.h */; };
E17B492216A9B8FF001C8839 /* JSTransitionEvent.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E17B492016A9B8FF001C8839 /* JSTransitionEvent.cpp */; };
E180810E16FCECDF00B80D07 /* WebCoreResourceHandleAsDelegate.mm in Sources */ = {isa = PBXBuildFile; fileRef = E180810C16FCECDF00B80D07 /* WebCoreResourceHandleAsDelegate.mm */; };
E180810F16FCECDF00B80D07 /* WebCoreResourceHandleAsDelegate.h in Headers */ = {isa = PBXBuildFile; fileRef = E180810D16FCECDF00B80D07 /* WebCoreResourceHandleAsDelegate.h */; };
E180811216FCF42F00B80D07 /* SynchronousLoaderClient.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E180811016FCF42E00B80D07 /* SynchronousLoaderClient.cpp */; };
E180811616FCF9CB00B80D07 /* SynchronousLoaderClient.mm in Sources */ = {isa = PBXBuildFile; fileRef = E180811416FCF9CB00B80D07 /* SynchronousLoaderClient.mm */; };
E180811716FCF9CB00B80D07 /* SynchronousLoaderClient.h in Headers */ = {isa = PBXBuildFile; fileRef = E180811516FCF9CB00B80D07 /* SynchronousLoaderClient.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -8738,6 +8742,8 @@
26F9A83718A046AC00AEB88A /* ViewportConfiguration.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ViewportConfiguration.h; sourceTree = "<group>"; };
26FAE4C81852E3A5004C8C46 /* ResourceHandleCFURLConnectionDelegate.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ResourceHandleCFURLConnectionDelegate.cpp; sourceTree = "<group>"; };
26FAE4C91852E3A5004C8C46 /* ResourceHandleCFURLConnectionDelegate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ResourceHandleCFURLConnectionDelegate.h; sourceTree = "<group>"; };
26FAE4CA1852E3A5004C8C46 /* SynchronousResourceHandleCFURLConnectionDelegate.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SynchronousResourceHandleCFURLConnectionDelegate.cpp; sourceTree = "<group>"; };
26FAE4CB1852E3A5004C8C46 /* SynchronousResourceHandleCFURLConnectionDelegate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SynchronousResourceHandleCFURLConnectionDelegate.h; sourceTree = "<group>"; };
2914E3051CAB5A440049966F /* AccessibilityAttachment.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = AccessibilityAttachment.cpp; sourceTree = "<group>"; };
2914E3061CAB5A440049966F /* AccessibilityAttachment.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = AccessibilityAttachment.h; sourceTree = "<group>"; };
2917B55E1473496C0052C9D0 /* LayerFlushScheduler.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = LayerFlushScheduler.cpp; sourceTree = "<group>"; };
@@ -15519,6 +15525,8 @@
E17B491416A9B093001C8839 /* TransitionEvent.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TransitionEvent.h; sourceTree = "<group>"; };
E17B491F16A9B8FF001C8839 /* JSTransitionEvent.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSTransitionEvent.h; sourceTree = "<group>"; };
E17B492016A9B8FF001C8839 /* JSTransitionEvent.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSTransitionEvent.cpp; sourceTree = "<group>"; };
E180810C16FCECDF00B80D07 /* WebCoreResourceHandleAsDelegate.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebCoreResourceHandleAsDelegate.mm; sourceTree = "<group>"; };
E180810D16FCECDF00B80D07 /* WebCoreResourceHandleAsDelegate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebCoreResourceHandleAsDelegate.h; sourceTree = "<group>"; };
E180811016FCF42E00B80D07 /* SynchronousLoaderClient.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SynchronousLoaderClient.cpp; sourceTree = "<group>"; };
E180811416FCF9CB00B80D07 /* SynchronousLoaderClient.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = SynchronousLoaderClient.mm; sourceTree = "<group>"; };
E180811516FCF9CB00B80D07 /* SynchronousLoaderClient.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SynchronousLoaderClient.h; sourceTree = "<group>"; };
@@ -19581,6 +19589,8 @@
E180811416FCF9CB00B80D07 /* SynchronousLoaderClient.mm */,
1FAFBF1615A5FA5200083A20 /* UTIUtilities.h */,
1FAFBF1715A5FA5200083A20 /* UTIUtilities.mm */,
E180810D16FCECDF00B80D07 /* WebCoreResourceHandleAsDelegate.h */,
E180810C16FCECDF00B80D07 /* WebCoreResourceHandleAsDelegate.mm */,
E152551316FD234F003D7ADB /* WebCoreResourceHandleAsOperationQueueDelegate.h */,
E152551416FD234F003D7ADB /* WebCoreResourceHandleAsOperationQueueDelegate.mm */,
37F818FB0D657606005E1F05 /* WebCoreURLResponse.h */,
@@ -24103,6 +24113,8 @@
51ABAE1C103C1913008C5260 /* SocketStreamHandleImpl.h */,
51ABAE1D103C1913008C5260 /* SocketStreamHandleImplCFNet.cpp */,
442ABCD517D9262F00D30715 /* SynchronousLoaderClientCFNet.cpp */,
26FAE4CA1852E3A5004C8C46 /* SynchronousResourceHandleCFURLConnectionDelegate.cpp */,
26FAE4CB1852E3A5004C8C46 /* SynchronousResourceHandleCFURLConnectionDelegate.h */,
);
path = cf;
sourceTree = "<group>";
@@ -30548,6 +30560,7 @@
51F645971F4A686F00B54DED /* SWServerRegistration.h in Headers */,
517A53461F50C17F00DCDC0A /* SWServerWorker.h in Headers */,
E180811716FCF9CB00B80D07 /* SynchronousLoaderClient.h in Headers */,
26FAE4CF1852E3A5004C8C46 /* SynchronousResourceHandleCFURLConnectionDelegate.h in Headers */,
0F03C0741884695E00A5F8CA /* SystemMemory.h in Headers */,
5D5975B319635F1100D00878 /* SystemVersion.h in Headers */,
A8CFF0510A154F09000A4234 /* TableLayout.h in Headers */,
@@ -30780,6 +30793,7 @@
CD225C0C1C46FBF400140761 /* WebCoreNSURLSession.h in Headers */,
DD05FE0D0B8BA3C6009ACDFE /* WebCoreObjCExtras.h in Headers */,
EDEC98030AED7E170059137F /* WebCorePrefix.h in Headers */,
E180810F16FCECDF00B80D07 /* WebCoreResourceHandleAsDelegate.h in Headers */,
E152551516FD2350003D7ADB /* WebCoreResourceHandleAsOperationQueueDelegate.h in Headers */,
A14832C7187F66C800DA63A6 /* WebCoreThread.h in Headers */,
A14832C9187F676B00DA63A6 /* WebCoreThreadInternal.h in Headers */,
@@ -34353,6 +34367,7 @@
E180811216FCF42F00B80D07 /* SynchronousLoaderClient.cpp in Sources */,
E180811616FCF9CB00B80D07 /* SynchronousLoaderClient.mm in Sources */,
442ABCD617D9262F00D30715 /* SynchronousLoaderClientCFNet.cpp in Sources */,
26FAE4CE1852E3A5004C8C46 /* SynchronousResourceHandleCFURLConnectionDelegate.cpp in Sources */,
E45390AE0EAFF4B5003695C8 /* SystemMemoryIOS.cpp in Sources */,
5D5975B419635F1100D00878 /* SystemVersion.mm in Sources */,
463EB6221B8789E00096ED51 /* TagCollection.cpp in Sources */,
@@ -34564,6 +34579,7 @@
CD225C0B1C46FBF400140761 /* WebCoreNSURLSession.mm in Sources */,
B50F5B810E96CD9900AD71A6 /* WebCoreObjCExtras.mm in Sources */,
9BDD18271F7E05F400E8E577 /* WebCorePasteboardFileReader.cpp in Sources */,
E180810E16FCECDF00B80D07 /* WebCoreResourceHandleAsDelegate.mm in Sources */,
E152551616FD2350003D7ADB /* WebCoreResourceHandleAsOperationQueueDelegate.mm in Sources */,
A14832C8187F673F00DA63A6 /* WebCoreThread.mm in Sources */,
A14832CB187F67B400DA63A6 /* WebCoreThreadRun.cpp in Sources */,
@@ -42,7 +42,7 @@ - (instancetype)initWithData:(NSData *)data URL:(NSURL *)URL MIMEType:(NSString
return nil;
}

resource = ArchiveResource::create(SharedBuffer::create(adoptNS([data copy]).get()), URL, MIMEType, textEncodingName, frameName, { });
resource = ArchiveResource::create(SharedBuffer::create(adoptNS([data copy]).get()), URL, MIMEType, textEncodingName, frameName, nil);
if (!resource) {
[self release];
return nil;

0 comments on commit 8d7ac95

Please sign in to comment.