Skip to content
Permalink
Browse files
run-webkit-tests: Driver.do_post_tests_work() is never called when `s…
…top_when_done` is true in Driver.run_test()

<https://webkit.org/b/201873>

Reviewed by Jonathan Bedard.

* Scripts/webkitpy/port/driver.py:
(Driver.run_test): Call self.do_post_tests_work() when a test
shard has completed, but didn't crash or time out.


Canonical link: https://commits.webkit.org/215516@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249965 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
ddkilzer committed Sep 17, 2019
1 parent f07701b commit 8eea869eb3e384a651866cebe6fdc3c616ec4a39
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
@@ -1,3 +1,14 @@
2019-09-17 David Kilzer <ddkilzer@apple.com>

run-webkit-tests: Driver.do_post_tests_work() is never called when `stop_when_done` is true in Driver.run_test()
<https://webkit.org/b/201873>

Reviewed by Jonathan Bedard.

* Scripts/webkitpy/port/driver.py:
(Driver.run_test): Call self.do_post_tests_work() when a test
shard has completed, but didn't crash or time out.

2019-09-17 Chris Dumez <cdumez@apple.com>

REGRESSION (r249923): ASSERTION FAILED: sessionID == WebProcess::singleton().sessionID() in WebCore::SWClientConnection *WebKit::WebServiceWorkerProvider::existingServiceWorkerConnectionForSession(PAL::SessionID)
@@ -221,6 +221,8 @@ def run_test(self, driver_input, stop_when_done):
pid = self._server_process.pid()

if stop_when_done or crashed or timed_out:
if stop_when_done and not (crashed or timed_out):
self.do_post_tests_work()
# We call stop() even if we crashed or timed out in order to get any remaining stdout/stderr output.
# In the timeout case, we kill the hung process as well.
out, err = self._server_process.stop(self._port.driver_stop_timeout() if stop_when_done else 0.0)

0 comments on commit 8eea869

Please sign in to comment.