Permalink
Show file tree
Hide file tree
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Stop allowing numbers during parsing of cx, cy, x, y CSS properties
https://bugs.webkit.org/show_bug.cgi?id=249479 Reviewed by Sam Weinig. Stop allowing numbers during parsing of cx, cy, x, y CSS properties. Per the specification, we should allow <length-percentage>, not <number>: - https://svgwg.org/svg2-draft/geometry.html#CX - https://svgwg.org/svg2-draft/geometry.html#CY - https://svgwg.org/svg2-draft/geometry.html#X - https://svgwg.org/svg2-draft/geometry.html#Y * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/center-coordinate-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/coordinate-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/svg/geometry/parsing/cx-invalid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/svg/geometry/parsing/cy-invalid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/svg/geometry/parsing/x-invalid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/svg/geometry/parsing/y-invalid-expected.txt: Rebaseline WPT tests now that more checks are passing. * Source/WebCore/css/CSSProperties.json: Use <length-percentage> instead of <length-percentage svg> for the parser grammar, since the svg attribute parsing mode allows unitless values. Canonical link: https://commits.webkit.org/258029@main
- Loading branch information
Showing
7 changed files
with
20 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
|
||
FAIL e.style['cx'] = "10" should not set the property value assert_equals: expected "" but got "10px" | ||
PASS e.style['cx'] = "10" should not set the property value | ||
PASS e.style['cx'] = "auto" should not set the property value | ||
PASS e.style['cx'] = "10px 20px" should not set the property value | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
|
||
FAIL e.style['cy'] = "10" should not set the property value assert_equals: expected "" but got "10px" | ||
PASS e.style['cy'] = "10" should not set the property value | ||
PASS e.style['cy'] = "auto" should not set the property value | ||
PASS e.style['cy'] = "10px 20px" should not set the property value | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
|
||
FAIL e.style['x'] = "10" should not set the property value assert_equals: expected "" but got "10px" | ||
PASS e.style['x'] = "10" should not set the property value | ||
PASS e.style['x'] = "auto" should not set the property value | ||
PASS e.style['x'] = "10px 20px" should not set the property value | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
|
||
FAIL e.style['y'] = "10" should not set the property value assert_equals: expected "" but got "10px" | ||
PASS e.style['y'] = "10" should not set the property value | ||
PASS e.style['y'] = "auto" should not set the property value | ||
PASS e.style['y'] = "10px 20px" should not set the property value | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters