Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Reviewed by Darin Adler.
        https://bugs.webkit.org/show_bug.cgi?id=24488
        An assertion failure when updating an offline application cache after emptying caches

        Emptying appcache cannot be performed automatically, so no test.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Ensure that the cache is in disk
        storage, even if the application wasn't updated server side.



Canonical link: https://commits.webkit.org/33616@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@41550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
aproskuryakov committed Mar 10, 2009
1 parent 290f32d commit 948ec22
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
13 changes: 13 additions & 0 deletions WebCore/ChangeLog
@@ -1,3 +1,16 @@
2009-03-10 Alexey Proskuryakov <ap@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24488
An assertion failure when updating an offline application cache after emptying caches

Emptying appcache cannot be performed automatically, so no test.

* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Ensure that the cache is in disk
storage, even if the application wasn't updated server side.

2009-03-10 Oliver Hunt <oliver@apple.com>

Reviewed by Alexey Proskuryakov.
Expand Down
6 changes: 5 additions & 1 deletion WebCore/loader/appcache/ApplicationCacheGroup.cpp
Expand Up @@ -707,7 +707,11 @@ void ApplicationCacheGroup::checkIfLoadIsComplete()
case NoUpdate:
ASSERT(isUpgradeAttempt);
ASSERT(!m_cacheBeingUpdated);
ASSERT(m_storageID);

// The storage could have been manually emptied by the user.
if (!m_storageID)
cacheStorage().storeNewestCache(this);

postListenerTask(&DOMApplicationCache::callNoUpdateListener, m_associatedDocumentLoaders);
break;
case Failure:
Expand Down

0 comments on commit 948ec22

Please sign in to comment.