XMLHttpRequest.open should use USVString

https://bugs.webkit.org/show_bug.cgi?id=215704

Patch by Rob Buis <rbuis@igalia.com> on 2020-08-20
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Update improved test result.

* web-platform-tests/xhr/open-url-encoding-expected.txt:

Source/WebCore:

XMLHttpRequest.open should use USVString as mentioned in the FIXMEs and the spec [1].

Test: imported/w3c/web-platform-tests/xhr/open-url-encoding.html

[1] https://xhr.spec.whatwg.org/#ref-for-dom-xmlhttprequest-open

* xml/XMLHttpRequest.idl:

Canonical link: https://commits.webkit.org/228461@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/imported/w3c/ChangeLog

@@ -1,3 +1,14 @@
+2020-08-20  Rob Buis  <rbuis@igalia.com>
+
+        XMLHttpRequest.open should use USVString
+        https://bugs.webkit.org/show_bug.cgi?id=215704
+
+        Reviewed by Chris Dumez.
+
+        Update improved test result.
+
+        * web-platform-tests/xhr/open-url-encoding-expected.txt:
+
 2020-08-20  Clark Wang  <clark_wang@apple.com>
 
         Introduce StereoPannerNode Interface

LayoutTests/imported/w3c/web-platform-tests/xhr/open-url-encoding-expected.txt

@@ -1,4 +1,4 @@
 
 PASS percent encode characters 
-FAIL lone surrogate assert_equals: expected "%26%2365533%3B" but got "%26%2355357%3B"
+PASS lone surrogate 
 

Source/WebCore/ChangeLog

@@ -1,3 +1,18 @@
+2020-08-20  Rob Buis  <rbuis@igalia.com>
+
+        XMLHttpRequest.open should use USVString
+        https://bugs.webkit.org/show_bug.cgi?id=215704
+
+        Reviewed by Chris Dumez.
+
+        XMLHttpRequest.open should use USVString as mentioned in the FIXMEs and the spec [1].
+
+        Test: imported/w3c/web-platform-tests/xhr/open-url-encoding.html
+
+        [1] https://xhr.spec.whatwg.org/#ref-for-dom-xmlhttprequest-open
+
+        * xml/XMLHttpRequest.idl:
+
 2020-08-20  Clark Wang  <clark_wang@apple.com>
 
         Introduce StereoPannerNode Interface

Source/WebCore/xml/XMLHttpRequest.idl

@@ -61,8 +61,8 @@ enum XMLHttpRequestResponseType {
     readonly attribute unsigned short readyState;
 
     // request
-    [MayThrowException] void open(ByteString method, DOMString url); // FIXME: url should be a USVString.
-    [MayThrowException] void open(ByteString method, DOMString url, boolean async, optional DOMString? user = null, optional DOMString? password = null); // FIXME: url/user/password should all be a USVStrings.
+    [MayThrowException] void open(ByteString method, USVString url);
+    [MayThrowException] void open(ByteString method, USVString url, boolean async, optional USVString? user = null, optional USVString? password = null);
     [MayThrowException] void setRequestHeader(ByteString header, ByteString value);
     attribute unsigned long timeout;
     attribute boolean withCredentials;