Skip to content
Permalink
Browse files
Fix spelling error in remote media players
https://bugs.webkit.org/show_bug.cgi?id=241786

Patch by Youssef Soliman <youssefdevelops@gmail.com> on 2022-06-20
Reviewed by Wenson Hsieh.

The word "identifier" was spelt wrong in both remote media player
header files and some supplemental media files.

* Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h:
* Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::identifier const): Deleted.
* Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h:

Canonical link: https://commits.webkit.org/251681@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
youssefsoli authored and webkit-commit-queue committed Jun 20, 2022
1 parent abcdaa9 commit 97d96daa046c3ad2de4cf310fa1333e6f176bd05
Showing 9 changed files with 18 additions and 25 deletions.
@@ -110,7 +110,7 @@ class RemoteMediaPlayerProxy final
RemoteMediaPlayerProxy(RemoteMediaPlayerManagerProxy&, WebCore::MediaPlayerIdentifier, Ref<IPC::Connection>&&, WebCore::MediaPlayerEnums::MediaEngineIdentifier, RemoteMediaPlayerProxyConfiguration&&, RemoteVideoFrameObjectHeap&, const WebCore::ProcessIdentity&);
~RemoteMediaPlayerProxy();

WebCore::MediaPlayerIdentifier idendifier() const { return m_id; }
WebCore::MediaPlayerIdentifier identifier() const { return m_id; }
void invalidate();

#if ENABLE(VIDEO_PRESENTATION_MODE)
@@ -36,10 +36,10 @@

namespace WebKit {

AudioTrackPrivateRemote::AudioTrackPrivateRemote(GPUProcessConnection& gpuProcessConnection, WebCore::MediaPlayerIdentifier playerIdentifier, TrackPrivateRemoteIdentifier idendifier, AudioTrackPrivateRemoteConfiguration&& configuration)
AudioTrackPrivateRemote::AudioTrackPrivateRemote(GPUProcessConnection& gpuProcessConnection, WebCore::MediaPlayerIdentifier playerIdentifier, TrackPrivateRemoteIdentifier identifier, AudioTrackPrivateRemoteConfiguration&& configuration)
: m_gpuProcessConnection(gpuProcessConnection)
, m_playerIdentifier(playerIdentifier)
, m_idendifier(idendifier)
, m_identifier(identifier)
{
updateConfiguration(WTFMove(configuration));
}
@@ -50,7 +50,7 @@ void AudioTrackPrivateRemote::setEnabled(bool enabled)
return;

if (enabled != this->enabled())
m_gpuProcessConnection->connection().send(Messages::RemoteMediaPlayerProxy::AudioTrackSetEnabled(m_idendifier, enabled), m_playerIdentifier);
m_gpuProcessConnection->connection().send(Messages::RemoteMediaPlayerProxy::AudioTrackSetEnabled(m_identifier, enabled), m_playerIdentifier);

AudioTrackPrivate::setEnabled(enabled);
}
@@ -41,9 +41,9 @@ struct AudioTrackPrivateRemoteConfiguration;
class AudioTrackPrivateRemote final : public WebCore::AudioTrackPrivate {
WTF_MAKE_NONCOPYABLE(AudioTrackPrivateRemote)
public:
static Ref<AudioTrackPrivateRemote> create(GPUProcessConnection& gpuProcessConnection, WebCore::MediaPlayerIdentifier playerIdentifier, TrackPrivateRemoteIdentifier idendifier, AudioTrackPrivateRemoteConfiguration&& configuration)
static Ref<AudioTrackPrivateRemote> create(GPUProcessConnection& gpuProcessConnection, WebCore::MediaPlayerIdentifier playerIdentifier, TrackPrivateRemoteIdentifier identifier, AudioTrackPrivateRemoteConfiguration&& configuration)
{
return adoptRef(*new AudioTrackPrivateRemote(gpuProcessConnection, playerIdentifier, idendifier, WTFMove(configuration)));
return adoptRef(*new AudioTrackPrivateRemote(gpuProcessConnection, playerIdentifier, identifier, WTFMove(configuration)));
}

AtomString id() const final { return m_id; }
@@ -69,7 +69,7 @@ class AudioTrackPrivateRemote final : public WebCore::AudioTrackPrivate {

MediaTime m_startTimeVariance { MediaTime::zeroTime() };
WebCore::MediaPlayerIdentifier m_playerIdentifier;
TrackPrivateRemoteIdentifier m_idendifier;
TrackPrivateRemoteIdentifier m_identifier;
};

} // namespace WebKit
@@ -1506,11 +1506,6 @@ WTFLogChannel& MediaPlayerPrivateRemote::logChannel() const
}
#endif

MediaPlayerIdentifier MediaPlayerPrivateRemote::identifier() const
{
return m_id;
}

} // namespace WebKit

#endif
@@ -93,7 +93,7 @@ class MediaPlayerPrivateRemote final
void didReceiveMessage(IPC::Connection&, IPC::Decoder&) final;

WebCore::MediaPlayerEnums::MediaEngineIdentifier remoteEngineIdentifier() const { return m_remoteEngineIdentifier; }
WebCore::MediaPlayerIdentifier itentifier() const { return m_id; }
WebCore::MediaPlayerIdentifier identifier() const final { return m_id; }
IPC::Connection& connection() const { return m_manager.gpuProcessConnection().connection(); }
WebCore::MediaPlayer* player() const { return m_player.get(); }

@@ -305,8 +305,6 @@ class MediaPlayerPrivateRemote final
bool shouldGetNativeImageForCanvasDrawing() const final { return false; }
#endif

WebCore::MediaPlayerIdentifier identifier() const final;

void setPreload(WebCore::MediaPlayer::Preload) final;

bool hasAvailableVideoFrame() const final;
@@ -37,11 +37,11 @@
namespace WebKit {
using namespace WebCore;

TextTrackPrivateRemote::TextTrackPrivateRemote(GPUProcessConnection& gpuProcessConnection, MediaPlayerIdentifier playerIdentifier, TrackPrivateRemoteIdentifier idendifier, TextTrackPrivateRemoteConfiguration&& configuration)
TextTrackPrivateRemote::TextTrackPrivateRemote(GPUProcessConnection& gpuProcessConnection, MediaPlayerIdentifier playerIdentifier, TrackPrivateRemoteIdentifier identifier, TextTrackPrivateRemoteConfiguration&& configuration)
: WebCore::InbandTextTrackPrivate(configuration.cueFormat)
, m_gpuProcessConnection(gpuProcessConnection)
, m_playerIdentifier(playerIdentifier)
, m_identifier(idendifier)
, m_identifier(identifier)
{
updateConfiguration(WTFMove(configuration));
}
@@ -48,9 +48,9 @@ class TextTrackPrivateRemote final : public WebCore::InbandTextTrackPrivate {
WTF_MAKE_NONCOPYABLE(TextTrackPrivateRemote)
public:

static Ref<TextTrackPrivateRemote> create(GPUProcessConnection& gpuProcessConnection, WebCore::MediaPlayerIdentifier playerIdentifier, TrackPrivateRemoteIdentifier idendifier, TextTrackPrivateRemoteConfiguration&& configuration)
static Ref<TextTrackPrivateRemote> create(GPUProcessConnection& gpuProcessConnection, WebCore::MediaPlayerIdentifier playerIdentifier, TrackPrivateRemoteIdentifier identifier, TextTrackPrivateRemoteConfiguration&& configuration)
{
return adoptRef(*new TextTrackPrivateRemote(gpuProcessConnection, playerIdentifier, idendifier, WTFMove(configuration)));
return adoptRef(*new TextTrackPrivateRemote(gpuProcessConnection, playerIdentifier, identifier, WTFMove(configuration)));
}

void addDataCue(MediaTime&& start, MediaTime&& end, IPC::DataReference&&);
@@ -36,10 +36,10 @@

namespace WebKit {

VideoTrackPrivateRemote::VideoTrackPrivateRemote(GPUProcessConnection& gpuProcessConnection, WebCore::MediaPlayerIdentifier playerIdentifier, TrackPrivateRemoteIdentifier idendifier, VideoTrackPrivateRemoteConfiguration&& configuration)
VideoTrackPrivateRemote::VideoTrackPrivateRemote(GPUProcessConnection& gpuProcessConnection, WebCore::MediaPlayerIdentifier playerIdentifier, TrackPrivateRemoteIdentifier identifier, VideoTrackPrivateRemoteConfiguration&& configuration)
: m_gpuProcessConnection(gpuProcessConnection)
, m_playerIdentifier(playerIdentifier)
, m_idendifier(idendifier)
, m_identifier(identifier)
{
updateConfiguration(WTFMove(configuration));
}
@@ -50,7 +50,7 @@ void VideoTrackPrivateRemote::setSelected(bool selected)
return;

if (selected != this->selected())
m_gpuProcessConnection->connection().send(Messages::RemoteMediaPlayerProxy::VideoTrackSetSelected(m_idendifier, selected), m_playerIdentifier);
m_gpuProcessConnection->connection().send(Messages::RemoteMediaPlayerProxy::VideoTrackSetSelected(m_identifier, selected), m_playerIdentifier);

VideoTrackPrivate::setSelected(selected);
}
@@ -42,9 +42,9 @@ class VideoTrackPrivateRemote
: public WebCore::VideoTrackPrivate {
WTF_MAKE_NONCOPYABLE(VideoTrackPrivateRemote)
public:
static Ref<VideoTrackPrivateRemote> create(GPUProcessConnection& gpuProcessConnection, WebCore::MediaPlayerIdentifier playerIdentifier, TrackPrivateRemoteIdentifier idendifier, VideoTrackPrivateRemoteConfiguration&& configuration)
static Ref<VideoTrackPrivateRemote> create(GPUProcessConnection& gpuProcessConnection, WebCore::MediaPlayerIdentifier playerIdentifier, TrackPrivateRemoteIdentifier identifier, VideoTrackPrivateRemoteConfiguration&& configuration)
{
return adoptRef(*new VideoTrackPrivateRemote(gpuProcessConnection, playerIdentifier, idendifier, WTFMove(configuration)));
return adoptRef(*new VideoTrackPrivateRemote(gpuProcessConnection, playerIdentifier, identifier, WTFMove(configuration)));
}

void updateConfiguration(VideoTrackPrivateRemoteConfiguration&&);
@@ -70,7 +70,7 @@ class VideoTrackPrivateRemote
AtomString m_language;
int m_trackIndex { -1 };
MediaTime m_startTimeVariance { MediaTime::zeroTime() };
TrackPrivateRemoteIdentifier m_idendifier;
TrackPrivateRemoteIdentifier m_identifier;
};

} // namespace WebKit

0 comments on commit 97d96da

Please sign in to comment.