Skip to content
Permalink
Browse files
[GTK] Enable Web Audio layout tests on WK2, provide platform-specific…
… expected output

https://bugs.webkit.org/show_bug.cgi?id=114513

Reviewed by Philippe Normand.

Unskip the Web Audio layout tests for GTK WK2 and generate platform-specific baselines for the tests.
The audio baselines are not audibly different from the generic baselines, but it can be expected that
different backends won't produce the same binary output.

The remaining failures are marked as such in the TestExpectations, each failure having the appropriate
bug handle covering the issue. The tests are still skipped for GTK WK1 as DumpRenderTree is still missing
infrastructure support for running these tests.

* platform/gtk-wk1/TestExpectations:
* platform/gtk/TestExpectations:
* platform/gtk/webaudio/audiobuffersource-loop-points-expected.wav: Added.
* platform/gtk/webaudio/audiobuffersource-playbackrate-expected.wav: Added.
* platform/gtk/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.wav: Added.
* platform/gtk/webaudio/codec-tests/mp3/128kbps-44khz-expected.wav: Added.
* platform/gtk/webaudio/codec-tests/vorbis/vbr-128kbps-44khz-expected.wav: Added.
* platform/gtk/webaudio/codec-tests/vorbis/vbr-70kbps-44khz-expected.wav: Added.
* platform/gtk/webaudio/codec-tests/vorbis/vbr-96kbps-44khz-expected.wav: Added.
* platform/gtk/webaudio/codec-tests/wav/24bit-22khz-resample-expected.wav: Added.
* platform/gtk/webaudio/codec-tests/wav/24bit-44khz-expected.wav: Added.
* platform/gtk/webaudio/oscillator-custom-expected.wav: Added.
* platform/gtk/webaudio/oscillator-sawtooth-expected.wav: Added.
* platform/gtk/webaudio/oscillator-sine-expected.wav: Added.
* platform/gtk/webaudio/oscillator-square-expected.wav: Added.
* platform/gtk/webaudio/oscillator-triangle-expected.wav: Added.


Canonical link: https://commits.webkit.org/133677@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
zdobersek committed Apr 26, 2013
1 parent ac4c210 commit 9901848
Show file tree
Hide file tree
Showing 17 changed files with 48 additions and 8 deletions.
@@ -1,3 +1,35 @@
2013-04-26 Zan Dobersek <zdobersek@igalia.com>

[GTK] Enable Web Audio layout tests on WK2, provide platform-specific expected output
https://bugs.webkit.org/show_bug.cgi?id=114513

Reviewed by Philippe Normand.

Unskip the Web Audio layout tests for GTK WK2 and generate platform-specific baselines for the tests.
The audio baselines are not audibly different from the generic baselines, but it can be expected that
different backends won't produce the same binary output.

The remaining failures are marked as such in the TestExpectations, each failure having the appropriate
bug handle covering the issue. The tests are still skipped for GTK WK1 as DumpRenderTree is still missing
infrastructure support for running these tests.

* platform/gtk-wk1/TestExpectations:
* platform/gtk/TestExpectations:
* platform/gtk/webaudio/audiobuffersource-loop-points-expected.wav: Added.
* platform/gtk/webaudio/audiobuffersource-playbackrate-expected.wav: Added.
* platform/gtk/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.wav: Added.
* platform/gtk/webaudio/codec-tests/mp3/128kbps-44khz-expected.wav: Added.
* platform/gtk/webaudio/codec-tests/vorbis/vbr-128kbps-44khz-expected.wav: Added.
* platform/gtk/webaudio/codec-tests/vorbis/vbr-70kbps-44khz-expected.wav: Added.
* platform/gtk/webaudio/codec-tests/vorbis/vbr-96kbps-44khz-expected.wav: Added.
* platform/gtk/webaudio/codec-tests/wav/24bit-22khz-resample-expected.wav: Added.
* platform/gtk/webaudio/codec-tests/wav/24bit-44khz-expected.wav: Added.
* platform/gtk/webaudio/oscillator-custom-expected.wav: Added.
* platform/gtk/webaudio/oscillator-sawtooth-expected.wav: Added.
* platform/gtk/webaudio/oscillator-sine-expected.wav: Added.
* platform/gtk/webaudio/oscillator-square-expected.wav: Added.
* platform/gtk/webaudio/oscillator-triangle-expected.wav: Added.

2013-04-26 Claudio Saavedra <csaavedra@igalia.com>

[GTK] Unreviewed gardnering. Unskip passing test.
@@ -101,6 +101,11 @@ webkit.org/b/108747 inspector-protocol/page/javascriptDialogEvents.html [ Failur
# This test is for clients that choose to make the missing plugin indicator a button
Bug(GTK) plugins/clicking-missing-plugin-fires-delegate.html [ Failure ]

# Support for Web Audio tests is missing in DumpRenderTree
webkit.org/b/67187 webaudio [ Skip ]
webkit.org/b/67187 webkit.org/b/102258 inspector-protocol/nmi-webaudio.html [ Skip ]
webkit.org/b/67187 inspector-protocol/nmi-webaudio-leak-test.html [ Skip ]

#////////////////////////////////////////////////////////////////////////////////////////
# End of Expected failures
#////////////////////////////////////////////////////////////////////////////////////////
@@ -257,14 +257,6 @@ webkit.org/b/99025 fast/dom/HTMLAnchorElement/anchor-download-unset.html [ Pass
# CSS Filters is disabled
webkit.org/b/99026 css3/filters [ Skip ]

# For now, Web Audio API is disabled
webkit.org/b/67187 webaudio [ Skip ]
webkit.org/b/67187 webkit.org/b/102258 inspector-protocol/nmi-webaudio.html [ Skip ]
webkit.org/b/67187 inspector-protocol/nmi-webaudio-leak-test.html [ Skip ]

# These tests include proprietary codecs.
webkit.org/b/67187 webaudio/codec-tests

# Needs testRunner.enableAutoResizeMode()
webkit.org/b/99028 fast/autoresize [ Failure ]

@@ -319,6 +311,8 @@ webkit.org/b/85212 ietestcenter/css3/flexbox/flexbox-layout-002.htm [ ImageOnlyF
# Mediastream implementation is not complete yet.
webkit.org/b/79203 fast/mediastream [ Skip ]
webkit.org/b/79203 fast/events/constructors/media-stream-event-constructor.html [ Skip ]
webkit.org/b/79203 webaudio/mediastreamaudiodestinationnode.html [ Skip ]
webkit.org/b/79203 webaudio/mediastreamaudiosourcenode.html [ Skip ]

# No CORS support for media elements is implemented yet.
webkit.org/b/99037 http/tests/security/video-cross-origin-readback.html [ Failure ]
@@ -1362,6 +1356,15 @@ webkit.org/b/114612 editing/style/block-style-005.html [ Failure ]
webkit.org/b/115025 fast/events/constructors/mouse-event-constructor.html [ Failure ]
webkit.org/b/115025 fast/events/constructors/wheel-event-constructor.html [ Failure ]

webkit.org/b/105296 webaudio/delaynode-max-nondefault-delay.html [ Failure ]
webkit.org/b/105296 webaudio/delaynode-maxdelay.html [ Failure ]
webkit.org/b/105296 webaudio/delaynode-scheduling.html [ Failure ]

webkit.org/b/105299 webaudio/javascriptaudionode.html [ Failure ]

webkit.org/b/105535 inspector-protocol/nmi-webaudio.html [ Failure ]
webkit.org/b/105535 inspector-protocol/nmi-webaudio-leak-test.html [ Timeout ]

#////////////////////////////////////////////////////////////////////////////////////////
# End of Tests failing
#////////////////////////////////////////////////////////////////////////////////////////
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.

0 comments on commit 9901848

Please sign in to comment.