Skip to content
Permalink
Browse files
Uncaught Exception: TypeError: null is not an object (evaluating 'thi…
…s.treeOutline.isXMLMimeType')

https://bugs.webkit.org/show_bug.cgi?id=178745

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-10-24
Reviewed by Brian Burg.

* UserInterface/Views/DOMTreeUpdater.js:
(WI.DOMTreeUpdater.prototype._updateModifiedNodes):
An earlier tree element update might have caused this other tree element's
waiting to be updated to actually be removed. So just skip past them.

Canonical link: https://commits.webkit.org/194923@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@223927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
JosephPecoraro authored and webkit-commit-queue committed Oct 24, 2017
1 parent 35f717a commit 99477b009312581359b0f78f74f6308f568807b9
Showing with 16 additions and 2 deletions.
  1. +12 −0 Source/WebInspectorUI/ChangeLog
  2. +4 −2 Source/WebInspectorUI/UserInterface/Views/DOMTreeUpdater.js
@@ -1,3 +1,15 @@
2017-10-24 Joseph Pecoraro <pecoraro@apple.com>

Uncaught Exception: TypeError: null is not an object (evaluating 'this.treeOutline.isXMLMimeType')
https://bugs.webkit.org/show_bug.cgi?id=178745

Reviewed by Brian Burg.

* UserInterface/Views/DOMTreeUpdater.js:
(WI.DOMTreeUpdater.prototype._updateModifiedNodes):
An earlier tree element update might have caused this other tree element's
waiting to be updated to actually be removed. So just skip past them.

2017-10-24 Fujii Hironori <Hironori.Fujii@sony.com>

[GTK] Web Inspector: Add Recording.svg
@@ -120,8 +120,10 @@ WI.DOMTreeUpdater.prototype = {
this._recentlyDeletedNodes.forEach(markNodeParentForUpdate);

for (let parentTreeElement of parentElementsToUpdate) {
parentTreeElement.updateTitle();
parentTreeElement.updateChildren();
if (parentTreeElement.treeOutline) {
parentTreeElement.updateTitle();
parentTreeElement.updateChildren();
}
}

for (let node of this._recentlyModifiedNodes.values()) {

0 comments on commit 99477b0

Please sign in to comment.