Permalink
Show file tree
Hide file tree
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Dedicated worker and shared worker global scope should use the respon…
…se URL https://bugs.webkit.org/show_bug.cgi?id=247615 rdar://problem/102088086 Reviewed by Chris Dumez. As per https://html.spec.whatwg.org/multipage/workers.html#run-a-worker step 14.3.1, we should use the response URL. Update the code accordingly, which allows removing the redirectReceived callback. Update DocumentThreadableLoader to provide a correct response URL, including fragment identifier. As DocumentThreadableLoader may reuse existing loads with same URL but different fragment identifier, we need to correctly set the response URL fragment identifier ourselves. Covered by rebased test. * LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/worker-interception-redirect.https-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/service-workers/service-worker/worker-interception-redirect.https-expected.txt: * Source/WebCore/loader/DocumentThreadableLoader.cpp: * Source/WebCore/loader/DocumentThreadableLoader.h: * Source/WebCore/loader/ThreadableLoaderClient.h: (WebCore::ThreadableLoaderClient::redirectReceived): Deleted. * Source/WebCore/loader/ThreadableLoaderClientWrapper.h: (WebCore::ThreadableLoaderClientWrapper::redirectReceived): Deleted. * Source/WebCore/loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::MainThreadBridge::redirectReceived): Deleted. * Source/WebCore/loader/WorkerThreadableLoader.h: * Source/WebCore/workers/Worker.cpp: (WebCore::Worker::notifyFinished): * Source/WebCore/workers/WorkerFetchResult.h: (WebCore::WorkerFetchResult::isolatedCopy const): (WebCore::WorkerFetchResult::encode const): (WebCore::WorkerFetchResult::decode): * Source/WebCore/workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::loadSynchronously): (WebCore::WorkerScriptLoader::loadAsynchronously): (WebCore::WorkerScriptLoader::fetchResult const): (WebCore::WorkerScriptLoader::redirectReceived): Deleted. * Source/WebCore/workers/WorkerScriptLoader.h: (WebCore::WorkerScriptLoader::url const): (WebCore::WorkerScriptLoader::lastRequestURL const): Deleted. * Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.cpp: (WebCore::generateWorkerParameters): * Source/WebKit/WebProcess/Storage/WebSharedWorkerContextManagerConnection.cpp: (WebKit::WebSharedWorkerContextManagerConnection::launchSharedWorker): Canonical link: https://commits.webkit.org/256532@main
- Loading branch information
Showing
14 changed files
with
31 additions
and
117 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.