Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Use visibleToHitTesting() in RenderLayerBacking::updateAfterDescendan…
…ts() instead of pointer-events check

https://bugs.webkit.org/show_bug.cgi?id=230681

Reviewed by Antti Koivisto.

The new check should account for inert as well once we implement it in RenderStyle.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateAfterDescendants):


Canonical link: https://commits.webkit.org/242047@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@282957 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
nt1m committed Sep 23, 2021
1 parent 969f93d commit 9aca456
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
12 changes: 12 additions & 0 deletions Source/WebCore/ChangeLog
@@ -1,3 +1,15 @@
2021-09-23 Tim Nguyen <ntim@apple.com>

Use visibleToHitTesting() in RenderLayerBacking::updateAfterDescendants() instead of pointer-events check
https://bugs.webkit.org/show_bug.cgi?id=230681

Reviewed by Antti Koivisto.

The new check should account for inert as well once we implement it in RenderStyle.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateAfterDescendants):

2021-09-23 Tim Nguyen <ntim@apple.com>

AX: Split out isInert from isAXHidden on AccessibilityObject
Expand Down
2 changes: 1 addition & 1 deletion Source/WebCore/rendering/RenderLayerBacking.cpp
Expand Up @@ -1590,7 +1590,7 @@ void RenderLayerBacking::updateAfterDescendants()
if (m_scrollContainerLayer) {
m_scrollContainerLayer->setContentsVisible(renderer().style().visibility() == Visibility::Visible);

bool userInteractive = renderer().style().pointerEvents() != PointerEvents::None;
bool userInteractive = renderer().visibleToHitTesting();
m_scrollContainerLayer->setUserInteractionEnabled(userInteractive);
if (m_layerForHorizontalScrollbar)
m_layerForHorizontalScrollbar->setUserInteractionEnabled(userInteractive);
Expand Down

0 comments on commit 9aca456

Please sign in to comment.