Skip to content
Permalink
Browse files
[GTK][WPE] Race condition when destroying webprocesses
https://bugs.webkit.org/show_bug.cgi?id=184445

Reviewed by Carlos Garcia Campos.

Ensure that the WebProcess is properly closing its pages when it's exiting because
the UIProcess has invalidated the IPC connection.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didClose):


Canonical link: https://commits.webkit.org/200006@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
magomez committed Apr 10, 2018
1 parent dfafac0 commit 9b9da43411aaee8b0dc228a0fdf1ff5374d3fbef
Showing with 16 additions and 1 deletion.
  1. +13 −0 Source/WebKit/ChangeLog
  2. +3 −1 Source/WebKit/WebProcess/WebProcess.cpp
@@ -1,3 +1,16 @@
2018-04-10 Miguel Gomez <magomez@igalia.com>

[GTK][WPE] Race condition when destroying webprocesses
https://bugs.webkit.org/show_bug.cgi?id=184445

Reviewed by Carlos Garcia Campos.

Ensure that the WebProcess is properly closing its pages when it's exiting because
the UIProcess has invalidated the IPC connection.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didClose):

2018-04-09 Wenson Hsieh <wenson_hsieh@apple.com>

Add missing availability macros after r230462
@@ -686,10 +686,12 @@ void WebProcess::didReceiveMessage(IPC::Connection& connection, IPC::Decoder& de

void WebProcess::didClose(IPC::Connection&)
{
#ifndef NDEBUG
#if !defined(NDEBUG) || PLATFORM(GTK) || PLATFORM(WPE)
for (auto& page : copyToVector(m_pageMap.values()))
page->close();
#endif

#ifndef NDEBUG
GCController::singleton().garbageCollectSoon();
FontCache::singleton().invalidate();
MemoryCache::singleton().setDisabled(true);

0 comments on commit 9b9da43

Please sign in to comment.