Skip to content
Permalink
Browse files
Correct web audio-related crash in seed reports
https://bugs.webkit.org/show_bug.cgi?id=200009
<rdar://problem/51565203>

Reviewed by Per Arne Vollan.

Source/WebCore:

Update the 'createMix' method to do proper return value checking so that
we can clear the result of MTAudioProcessingTapCreate if the create operation
failed.

* platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::createMix):

Source/WebKit:

Revise the iOS sandbox to allow the WebContent process to communicate with
the 'com.apple.coremedia.audioprocessingtap.xpc' service, which is needed by
some types of WebAudio.

* WebProcess/com.apple.WebKit.WebContent.sb.in:


Canonical link: https://commits.webkit.org/213863@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
brentfulgham committed Jul 22, 2019
1 parent 03d4c4c commit a0b7cb8e0697ba2e6d96ae7e770666efbd237634
Showing 4 changed files with 34 additions and 2 deletions.
@@ -1,3 +1,18 @@
2019-07-22 Brent Fulgham <bfulgham@apple.com>

Correct web audio-related crash in seed reports
https://bugs.webkit.org/show_bug.cgi?id=200009
<rdar://problem/51565203>

Reviewed by Per Arne Vollan.

Update the 'createMix' method to do proper return value checking so that
we can clear the result of MTAudioProcessingTapCreate if the create operation
failed.

* platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::createMix):

2019-07-22 Per Arne Vollan <pvollan@apple.com>

Prewarmed font does not find any matches
@@ -216,9 +216,13 @@
};

MTAudioProcessingTapRef tap = nullptr;
MTAudioProcessingTapCreate(kCFAllocatorDefault, &callbacks, 1, &tap);
OSStatus status = MTAudioProcessingTapCreate(kCFAllocatorDefault, &callbacks, 1, &tap);
ASSERT(tap);
ASSERT(m_tap == tap);
if (status != noErr) {
m_tap = nullptr;
return;
}

RetainPtr<AVMutableAudioMixInputParameters> parameters = adoptNS([PAL::allocAVMutableAudioMixInputParametersInstance() init]);
[parameters setAudioTapProcessor:m_tap.get()];
@@ -1,3 +1,17 @@
2019-07-22 Brent Fulgham <bfulgham@apple.com>

Correct web audio-related crash in seed reports
https://bugs.webkit.org/show_bug.cgi?id=200009
<rdar://problem/51565203>

Reviewed by Per Arne Vollan.

Revise the iOS sandbox to allow the WebContent process to communicate with
the 'com.apple.coremedia.audioprocessingtap.xpc' service, which is needed by
some types of WebAudio.

* WebProcess/com.apple.WebKit.WebContent.sb.in:

2019-07-22 Dean Jackson <dino@apple.com>

WebKit SPI fix for [ClickyOrb] Audio continues playing after dismissing a video preview in Safari
@@ -424,7 +424,6 @@
(global-name "com.apple.containermanagerd")
(global-name "com.apple.coremedia.assetcacheinspector")
(global-name "com.apple.coremedia.audiodeviceclock")
(global-name "com.apple.coremedia.audioprocessingtap.xpc")
(global-name "com.apple.coremedia.endpointremotecontrolsession.xpc")
(global-name "com.apple.coremedia.sandboxserver")
(global-name "com.apple.coremedia.videocompositor")

0 comments on commit a0b7cb8

Please sign in to comment.