Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
WorkerGlobalScopeWebDatabase requires ENABLE(WORKERS)
https://bugs.webkit.org/show_bug.cgi?id=120395

Reviewed by Christophe Dumez.

WorkerGlobalScopeDatabase uses the WorkerGlobalScope object which is
defined only when WORKERS are enabled. We should guard that code.

* Modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp:
* Modules/webdatabase/WorkerGlobalScopeWebDatabase.h:
* Modules/webdatabase/WorkerGlobalScopeWebDatabase.idl:

Canonical link: https://commits.webkit.org/138372@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@154732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Sergio Villar Senin committed Aug 28, 2013
1 parent 3c9c3d0 commit a186c95
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 5 deletions.
14 changes: 14 additions & 0 deletions Source/WebCore/ChangeLog
@@ -1,3 +1,17 @@
2013-08-28 Sergio Villar Senin <svillar@igalia.com>

WorkerGlobalScopeWebDatabase requires ENABLE(WORKERS)
https://bugs.webkit.org/show_bug.cgi?id=120395

Reviewed by Christophe Dumez.

WorkerGlobalScopeDatabase uses the WorkerGlobalScope object which is
defined only when WORKERS are enabled. We should guard that code.

* Modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp:
* Modules/webdatabase/WorkerGlobalScopeWebDatabase.h:
* Modules/webdatabase/WorkerGlobalScopeWebDatabase.idl:

2013-08-28 Sergio Villar Senin <svillar@igalia.com>

[CSS Grid Layout] Fix grid position resolution
Expand Down
Expand Up @@ -27,7 +27,7 @@

#include "config.h"

#if ENABLE(SQL_DATABASE)
#if ENABLE(SQL_DATABASE) && ENABLE(WORKERS)

#include "WorkerGlobalScopeWebDatabase.h"

Expand Down Expand Up @@ -73,4 +73,4 @@ PassRefPtr<DatabaseSync> WorkerGlobalScopeWebDatabase::openDatabaseSync(WorkerGl

} // namespace WebCore

#endif // ENABLE(SQL_DATABASE)
#endif // ENABLE(SQL_DATABASE) && ENABLE(WORKERS)
Expand Up @@ -27,7 +27,7 @@
#ifndef WorkerGlobalScopeWebDatabase_h
#define WorkerGlobalScopeWebDatabase_h

#if ENABLE(SQL_DATABASE)
#if ENABLE(SQL_DATABASE) && ENABLE(WORKERS)

#include "ExceptionCode.h"
#include <wtf/Forward.h>
Expand All @@ -54,6 +54,6 @@ class WorkerGlobalScopeWebDatabase {

} // namespace WebCore

#endif // ENABLE(SQL_DATABASE)
#endif // ENABLE(SQL_DATABASE) && ENABLE(WORKERS)

#endif // WorkerGlobalScopeWebDatabase_h
Expand Up @@ -25,7 +25,7 @@
*/

[
Conditional=SQL_DATABASE,
Conditional=SQL_DATABASE&WORKERS,
] partial interface WorkerGlobalScope {
[RaisesException] Database openDatabase(DOMString name, DOMString version, DOMString displayName, unsigned long estimatedSize, optional DatabaseCallback creationCallback);

Expand Down

0 comments on commit a186c95

Please sign in to comment.