Please sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
2010-07-18 Dean Jackson <email@example.com>
Reviewed by Simon Fraser. https://bugs.webkit.org/show_bug.cgi?id=41259 Interacting with a <select> element within a transformed and clipped container scrolls the container The Node::getRect and ContainerNode::getRect functions were not transform-aware. This fixes both, and has a test to make sure we're not breaking any existing scrollToView code. This means that a <select> popup will appear in the correct place if it is within a transformed and scrolled container. The test makes sure that existing scrollToView code doesn't break, but also checks that a <select> popup will appear in the correct place. Test: fast/transforms/scrollIntoView-transformed.html * dom/ContainerNode.cpp: (WebCore::ContainerNode::getUpperLeftCorner): (WebCore::ContainerNode::getLowerRightCorner): - make sure we call localToAbsolute in the right order (after we've done a local move) and pass in the flags to indicate it should look for transforms. * dom/Node.cpp: (WebCore::Node::getRect): - make sure localToAbsolute gets told to look for transforms. Canonical link: https://commits.webkit.org/54473@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing with 365 additions and 8 deletions.
- +16 −0 LayoutTests/ChangeLog
- +78 −0 LayoutTests/fast/transforms/scrollIntoView-transformed-expected.txt
- +236 −0 LayoutTests/fast/transforms/scrollIntoView-transformed.html
- +26 −0 WebCore/ChangeLog
- +1 −0 WebCore/WebCore.xcodeproj/project.pbxproj
- +7 −6 WebCore/dom/ContainerNode.cpp
- +1 −2 WebCore/dom/Node.cpp
There are no files selected for viewing
Oops, something went wrong.