Skip to content
Permalink
Browse files
[Debug][GStreamer] Crash in fast/mediastream/get-display-media-settin…
…gs.html

https://bugs.webkit.org/show_bug.cgi?id=235221

Patch by Philippe Normand <pnormand@igalia.com> on 2022-01-17
Reviewed by Xabier Rodriguez-Calvar.

Fix use-after-move issue in MockDisplayCaptureSourceGStreamer. The hashSalt string was moved
to the wrapped mock video source, and then again as a parent class constructor parameter.

* platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp:
(WebCore::MockDisplayCaptureSourceGStreamer::create):


Canonical link: https://commits.webkit.org/246105@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288091 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
philn authored and webkit-commit-queue committed Jan 17, 2022
1 parent 4260905 commit a2b6236f7a918ad3dd2879af4f044c750d3e10d3
Showing 2 changed files with 14 additions and 1 deletion.
@@ -1,3 +1,16 @@
2022-01-17 Philippe Normand <pnormand@igalia.com>

[Debug][GStreamer] Crash in fast/mediastream/get-display-media-settings.html
https://bugs.webkit.org/show_bug.cgi?id=235221

Reviewed by Xabier Rodriguez-Calvar.

Fix use-after-move issue in MockDisplayCaptureSourceGStreamer. The hashSalt string was moved
to the wrapped mock video source, and then again as a parent class constructor parameter.

* platform/mediastream/gstreamer/MockRealtimeVideoSourceGStreamer.cpp:
(WebCore::MockDisplayCaptureSourceGStreamer::create):

2022-01-17 Carlos Garcia Campos <cgarcia@igalia.com>

[GTK][a11y] Stop using isolated tree for the ATSPI implementation
@@ -52,7 +52,7 @@ CaptureSourceOrError MockRealtimeVideoSource::create(String&& deviceID, String&&

CaptureSourceOrError MockDisplayCaptureSourceGStreamer::create(const CaptureDevice& device, String&& hashSalt, const MediaConstraints* constraints)
{
auto mockSource = adoptRef(*new MockRealtimeVideoSourceGStreamer(String { device.persistentId() }, String { device.label() }, WTFMove(hashSalt)));
auto mockSource = adoptRef(*new MockRealtimeVideoSourceGStreamer(String { device.persistentId() }, String { device.label() }, String { hashSalt }));

if (constraints) {
if (auto error = mockSource->applyConstraints(*constraints))

0 comments on commit a2b6236

Please sign in to comment.