Skip to content
Permalink
Browse files
Updating RTCPeerConnectionHandlerMock after r159769
https://bugs.webkit.org/show_bug.cgi?id=124947

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-28
Reviewed by Philippe Normand.

Adding its create function back, in order to run RTCPeerConnection LayoutTests.

No new tests needed.

* platform/mock/RTCPeerConnectionHandlerMock.cpp:
(WebCore::RTCPeerConnectionHandlerMock::create):
* platform/mock/RTCPeerConnectionHandlerMock.h:

Canonical link: https://commits.webkit.org/143091@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159840 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Thiago de Barros Lacerda authored and webkit-commit-queue committed Nov 28, 2013
1 parent 3f77d92 commit a2d88021eab2f23c4b9d99bde91e8e99092f69fe
Showing 3 changed files with 22 additions and 1 deletion.
@@ -1,3 +1,18 @@
2013-11-28 Thiago de Barros Lacerda <thiago.lacerda@openbossa.org>

Updating RTCPeerConnectionHandlerMock after r159769
https://bugs.webkit.org/show_bug.cgi?id=124947

Reviewed by Philippe Normand.

Adding its create function back, in order to run RTCPeerConnection LayoutTests.

No new tests needed.

* platform/mock/RTCPeerConnectionHandlerMock.cpp:
(WebCore::RTCPeerConnectionHandlerMock::create):
* platform/mock/RTCPeerConnectionHandlerMock.h:

2013-11-27 Gustavo Noronha Silva <gustavo.noronha@collabora.com>

[GTK] Support custom types for drag and drop data
@@ -41,6 +41,11 @@

namespace WebCore {

std::unique_ptr<RTCPeerConnectionHandler> RTCPeerConnectionHandlerMock::create(RTCPeerConnectionHandlerClient* client)
{
return std::make_unique<RTCPeerConnectionHandlerMock>(client);
}

RTCPeerConnectionHandlerMock::RTCPeerConnectionHandlerMock(RTCPeerConnectionHandlerClient* client)
: m_client(client)
{
@@ -36,6 +36,8 @@ namespace WebCore {

class RTCPeerConnectionHandlerMock FINAL : public RTCPeerConnectionHandler, public TimerEventBasedMock {
public:
static std::unique_ptr<RTCPeerConnectionHandler> create(RTCPeerConnectionHandlerClient*);

virtual ~RTCPeerConnectionHandlerMock() { }

virtual bool initialize(PassRefPtr<RTCConfiguration>, PassRefPtr<MediaConstraints>) OVERRIDE;
@@ -55,7 +57,6 @@ class RTCPeerConnectionHandlerMock FINAL : public RTCPeerConnectionHandler, publ
virtual std::unique_ptr<RTCDTMFSenderHandler> createDTMFSender(PassRefPtr<MediaStreamSource>) OVERRIDE;
virtual void stop() OVERRIDE;

protected:
explicit RTCPeerConnectionHandlerMock(RTCPeerConnectionHandlerClient*);

private:

0 comments on commit a2d8802

Please sign in to comment.