Skip to content
Permalink
Browse files
Unreviewed, rolling out r251646.
Caused flakey API failures for GetDisplayMediaTest.Constraints

Reverted changeset:

"Unreviewed build fix for !ENABLE(MEDIA_STREAM) builds"
https://bugs.webkit.org/show_bug.cgi?id=203362
https://trac.webkit.org/changeset/251646

Canonical link: https://commits.webkit.org/216935@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251711 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Technose committed Oct 29, 2019
1 parent 06a3877 commit a3a66b3b6d5e40c7cb62711f4314c6c7697def45
Showing 2 changed files with 12 additions and 2 deletions.
@@ -1,3 +1,15 @@
2019-10-29 Truitt Savell <tsavell@apple.com>

Unreviewed, rolling out r251646.

Caused flakey API failures for GetDisplayMediaTest.Constraints

Reverted changeset:

"Unreviewed build fix for !ENABLE(MEDIA_STREAM) builds"
https://bugs.webkit.org/show_bug.cgi?id=203362
https://trac.webkit.org/changeset/251646

2019-10-29 Chris Dumez <cdumez@apple.com>

Unreviewed, rolling out r251594.
@@ -84,9 +84,7 @@ class UserMediaPermissionRequestProxy : public API::ObjectImpl<API::Object::Type
WebCore::CaptureDevice audioDevice() const { return m_eligibleAudioDevices.isEmpty() ? WebCore::CaptureDevice { } : m_eligibleAudioDevices[0]; }
WebCore::CaptureDevice videoDevice() const { return m_eligibleVideoDevices.isEmpty() ? WebCore::CaptureDevice { } : m_eligibleVideoDevices[0]; }

#if ENABLE(MEDIA_STREAM)
bool isUserGesturePriviledged() const { return m_request.isUserGesturePriviledged; }
#endif

private:
UserMediaPermissionRequestProxy(UserMediaPermissionRequestManagerProxy&, uint64_t userMediaID, WebCore::FrameIdentifier mainFrameID, WebCore::FrameIdentifier, Ref<WebCore::SecurityOrigin>&& userMediaDocumentOrigin, Ref<WebCore::SecurityOrigin>&& topLevelDocumentOrigin, Vector<WebCore::CaptureDevice>&& audioDevices, Vector<WebCore::CaptureDevice>&& videoDevices, WebCore::MediaStreamRequest&&);

0 comments on commit a3a66b3

Please sign in to comment.