Skip to content
Permalink
Browse files
2009-11-09 Carol Szabo <carol.szabo@nokia.com>
        Reviewed by Darin Adler.

        showTree(CounterNode*) generates too little info and has too many spaces.
        https://bugs.webkit.org/show_bug.cgi?id=31212

        No new tests as the change has no functional effect it is just for
        improved debugging.

        * rendering/CounterNode.cpp:
        (WebCore::showTreeAndMark):
        Changed to also show addresses of parent, next and previous
        siblings.

Canonical link: https://commits.webkit.org/42103@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
eseidel committed Nov 9, 2009
1 parent 6875900 commit a3ecb5f43db1c27b294d9b24509fc07f5f819e8c
Showing with 23 additions and 9 deletions.
  1. +15 −0 WebCore/ChangeLog
  2. +8 −9 WebCore/rendering/CounterNode.cpp
@@ -1,3 +1,18 @@
2009-11-09 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Darin Adler.

showTree(CounterNode*) generates too little info and has too many spaces.
https://bugs.webkit.org/show_bug.cgi?id=31212

No new tests as the change has no functional effect it is just for
improved debugging.

* rendering/CounterNode.cpp:
(WebCore::showTreeAndMark):
Changed to also show addresses of parent, next and previous
siblings.

2009-11-09 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Darin Adler.
@@ -169,15 +169,14 @@ static void showTreeAndMark(const CounterNode* node)
while (root->parent())
root = root->parent();

for (const CounterNode* c = root; c; c = nextInPreOrder(c)) {
if (c == node)
fprintf(stderr, "*");
for (const CounterNode* d = c; d && d != root; d = d->parent())
fprintf(stderr, "\t");
if (c->isReset())
fprintf(stderr, "reset: %d %d\n", c->value(), c->countInParent());
else
fprintf(stderr, "increment: %d %d\n", c->value(), c->countInParent());
for (const CounterNode* current = root; current; current = nextInPreOrder(current)) {
fwrite((current == node) ? "*" : " ", 1, 1, stderr);
for (const CounterNode* parent = current; parent && parent != root; parent = parent->parent())
fwrite(" ", 1, 2, stderr);
fprintf(stderr, "%p %s: %d %d P:%p PS:%p NS:%p R:%p\n",
current, current->isReset() ? "reset____" : "increment", current->value(),
current->countInParent(), current->parent(), current->previousSibling(),
current->nextSibling(), current->renderer());
}
}

0 comments on commit a3ecb5f

Please sign in to comment.