Skip to content
Permalink
Browse files
2011-05-24 Adam Klein <adamk@chromium.org>
        Unreviewed, rolling out r87145.
        http://trac.webkit.org/changeset/87145
        https://bugs.webkit.org/show_bug.cgi?id=61194

        Regression in LayoutTests/inspector/debugger/scripts-panel.html on Chromium Win & Linux.

        * inspector/console/console-eval-syntax-error-expected.txt: Removed.
        * inspector/console/console-eval-syntax-error.html: Removed.
        * platform/chromium/inspector/console/console-eval-syntax-error-expected.txt: Removed.
2011-05-24  Adam Klein  <adamk@chromium.org>

        Unreviewed, rolling out r87145.
        http://trac.webkit.org/changeset/87145
        https://bugs.webkit.org/show_bug.cgi?id=61194

        Regression in LayoutTests/inspector/debugger/scripts-panel.html on Chromium Win & Linux.

        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::V8InjectedScriptHost::evaluateCallback):

Canonical link: https://commits.webkit.org/76752@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87172 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
ajklein committed May 24, 2011
1 parent d3cc55d commit a55d63cddcad2f101aadc20d07d858bdd0de8485
@@ -1,3 +1,15 @@
2011-05-24 Adam Klein <adamk@chromium.org>

Unreviewed, rolling out r87145.
http://trac.webkit.org/changeset/87145
https://bugs.webkit.org/show_bug.cgi?id=61194

Regression in LayoutTests/inspector/debugger/scripts-panel.html on Chromium Win & Linux.

* inspector/console/console-eval-syntax-error-expected.txt: Removed.
* inspector/console/console-eval-syntax-error.html: Removed.
* platform/chromium/inspector/console/console-eval-syntax-error-expected.txt: Removed.

2011-05-24 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

This file was deleted.

This file was deleted.

This file was deleted.

@@ -1,3 +1,14 @@
2011-05-24 Adam Klein <adamk@chromium.org>

Unreviewed, rolling out r87145.
http://trac.webkit.org/changeset/87145
https://bugs.webkit.org/show_bug.cgi?id=61194

Regression in LayoutTests/inspector/debugger/scripts-panel.html on Chromium Win & Linux.

* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::evaluateCallback):

2011-05-24 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.
@@ -76,8 +76,6 @@ v8::Handle<v8::Value> V8InjectedScriptHost::evaluateCallback(const v8::Arguments
return v8::ThrowException(v8::Exception::Error(v8::String::New("The argument must be a string.")));

v8::Handle<v8::Script> script = v8::Script::Compile(expression);
if (script.IsEmpty()) // Return immediately in case of exception to let the caller handle it.
return v8::Handle<v8::Value>();
return script->Run();
}

0 comments on commit a55d63c

Please sign in to comment.