Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Web Inspector: Styles: CSS documentation popover is needlessly persis…
…tent with broken background https://bugs.webkit.org/show_bug.cgi?id=242338 Reviewed by Devin Rousso. Prevent the CSS documentation popover from staying visible when clicking on the CSS value field. Avoids having multiple popovers shown at the same time as a result of clicking on inline swatches. The original intent to keep the the documentation popover visible while editing a CSS value was that a user could reference the syntax section. But the syntax section is not shown because most entries are written with specialized identifiers to aid spec implementers, not users. We don't yet have a solution to make it user-legible so the syntax section remains hidden. Given this constraint, it doesn't make sense to keep the CSS documentation open while clicking or typing in the CSS value field. An implementation side-effect makes the lingering popover background look broken. Its background is drawn as a CSS image, `background: -webkit-canvas(popover)`, sourced from a shared canvas context: `document.getCSSCanvasContext("2d", "popover", scaledWidth, scaledHeight)`. When another popover is shown, it redraws the image on the canvas which is then reflected on all visible popovers. * Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js: (WI.SpreadsheetStyleProperty.prototype.willDismissPopover): (WI.SpreadsheetStyleProperty.prototype._presentCSSDocumentation): Canonical link: https://commits.webkit.org/252175@main
- Loading branch information