Skip to content
Permalink
Browse files
SizesAttributeParser::SizesAttributeParser triggers layout
https://bugs.webkit.org/show_bug.cgi?id=178712

Reviewed by Antti Koivisto.

Revert r213711 as this change introduced an unwated synchronous layout inside Node::insertedIntoAncestor.

The test had been marked as timing out since r191379 and changed to failing expectation in r199225
as the test result's error message changes from run to run.

Disabled Tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change.html
                had been marked failing since r199225, prior to which it was marked as timeout in r191379.
                imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute.html
                is now marked as flaky.

* css/parser/SizesAttributeParser.cpp:
(WebCore::SizesAttributeParser::SizesAttributeParser):


Canonical link: https://commits.webkit.org/194891@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@223895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
rniwa committed Oct 24, 2017
1 parent fbaf154 commit a57e58867d56cef9ee692e917b87ef743415eef3
Showing with 21 additions and 4 deletions.
  1. +1 −0 LayoutTests/TestExpectations
  2. +20 −0 Source/WebCore/ChangeLog
  3. +0 −4 Source/WebCore/css/parser/SizesAttributeParser.cpp
@@ -656,6 +656,7 @@ imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-tex

imported/w3c/web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/010.html [ Failure Timeout ]
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change.html [ Failure ]
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute.html [ Pass Failure ]

# Imported Mozilla SVG tests
webkit.org/b/5968 imported/mozilla/svg/linearGradient-basic-03.svg [ ImageOnlyFailure ]
@@ -1,3 +1,23 @@
2017-10-24 Ryosuke Niwa <rniwa@webkit.org>

SizesAttributeParser::SizesAttributeParser triggers layout
https://bugs.webkit.org/show_bug.cgi?id=178712

Reviewed by Antti Koivisto.

Revert r213711 as this change introduced an unwated synchronous layout inside Node::insertedIntoAncestor.

The test had been marked as timing out since r191379 and changed to failing expectation in r199225
as the test result's error message changes from run to run.

Disabled Tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change.html
had been marked failing since r199225, prior to which it was marked as timeout in r191379.
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute.html
is now marked as flaky.

* css/parser/SizesAttributeParser.cpp:
(WebCore::SizesAttributeParser::SizesAttributeParser):

2017-10-24 Keith Miller <keith_miller@apple.com>

Unreviewed, fix internal iOS build.
@@ -73,10 +73,6 @@ SizesAttributeParser::SizesAttributeParser(const String& attribute, const Docume
, m_length(0)
, m_lengthWasSet(false)
{
// Ensure iframes have correct view size.
if (m_document.ownerElement())
m_document.ownerElement()->document().updateLayoutIgnorePendingStylesheets();

m_isValid = parse(CSSTokenizer(attribute).tokenRange());
}

0 comments on commit a57e588

Please sign in to comment.