SizesAttributeParser::SizesAttributeParser triggers layout

https://bugs.webkit.org/show_bug.cgi?id=178712

Reviewed by Antti Koivisto.

Revert r213711 as this change introduced an unwated synchronous layout inside Node::insertedIntoAncestor.

The test had been marked as timing out since r191379 and changed to failing expectation in r199225
as the test result's error message changes from run to run.

Disabled Tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change.html
                had been marked failing since r199225, prior to which it was marked as timeout in r191379.
                imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute.html
                is now marked as flaky.

* css/parser/SizesAttributeParser.cpp:
(WebCore::SizesAttributeParser::SizesAttributeParser):


Canonical link: https://commits.webkit.org/194891@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@223895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/TestExpectations

@@ -656,6 +656,7 @@ imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-tex
 
 imported/w3c/web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/010.html [ Failure Timeout ]
 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change.html [ Failure ]
+imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute.html [ Pass Failure ]
 
 # Imported Mozilla SVG tests
 webkit.org/b/5968 imported/mozilla/svg/linearGradient-basic-03.svg [ ImageOnlyFailure ]

Source/WebCore/ChangeLog

@@ -1,3 +1,23 @@
+2017-10-24  Ryosuke Niwa  <rniwa@webkit.org>
+
+        SizesAttributeParser::SizesAttributeParser triggers layout
+        https://bugs.webkit.org/show_bug.cgi?id=178712
+
+        Reviewed by Antti Koivisto.
+
+        Revert r213711 as this change introduced an unwated synchronous layout inside Node::insertedIntoAncestor.
+
+        The test had been marked as timing out since r191379 and changed to failing expectation in r199225
+        as the test result's error message changes from run to run.
+
+        Disabled Tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change.html
+                        had been marked failing since r199225, prior to which it was marked as timeout in r191379.
+                        imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute.html
+                        is now marked as flaky.
+
+        * css/parser/SizesAttributeParser.cpp:
+        (WebCore::SizesAttributeParser::SizesAttributeParser):
+
 2017-10-24  Keith Miller  <keith_miller@apple.com>
 
         Unreviewed, fix internal iOS build.

Source/WebCore/css/parser/SizesAttributeParser.cpp

@@ -73,10 +73,6 @@ SizesAttributeParser::SizesAttributeParser(const String& attribute, const Docume
     , m_length(0)
     , m_lengthWasSet(false)
 {
-    // Ensure iframes have correct view size.
-    if (m_document.ownerElement())
-        m_document.ownerElement()->document().updateLayoutIgnorePendingStylesheets();
-
     m_isValid = parse(CSSTokenizer(attribute).tokenRange());
 }