[css-ui] alias appearance <compat-auto> keywords to 'auto' for textfield

https://bugs.webkit.org/show_bug.cgi?id=238551

Reviewed by Tim Nguyen.

Source/WebCore:

This is to add support of aliasing appearance to 'auto' for textfield.
It has improved the following wpt tests
imported/w3c/web-platform-tests/css/css-ui/appearance-textfield-001.html
and
imported/w3c/web-platform-tests/css/css-ui/webkit-appearance-textfield-001.html.

The test failures though, are not fully fixed. The issue left is that the search cancel button
for input type="search" still present while it is expected to disappear (Bug 238751).

* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustAppearanceForElement const):

LayoutTests:

Rename test name as the test result now matches the expected.
* fast/forms/color/color-input-uses-color-well-appearance-expected.html: Renamed from LayoutTests/fast/forms/color/color-input-uses-color-well-appearance-expected-mismatch.html.

Canonical link: https://commits.webkit.org/250605@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog

@@ -1,3 +1,13 @@
+2022-05-16  Ziran Sun  <zsun@igalia.com>
+
+        [css-ui] alias appearance <compat-auto> keywords to 'auto' for textfield
+        https://bugs.webkit.org/show_bug.cgi?id=238551
+
+        Reviewed by Tim Nguyen.
+
+        Rename test name as the test result now matches the expected.
+        * fast/forms/color/color-input-uses-color-well-appearance-expected.html: Renamed from LayoutTests/fast/forms/color/color-input-uses-color-well-appearance-expected-mismatch.html.
+
 2022-05-16  Karl Rackler  <rackler@apple.com>
 
         [Gardening]: REGRESSION (r264117): [ Mac iOS ] imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/blob.https.html

Source/WebCore/ChangeLog

@@ -1,3 +1,22 @@
+2022-05-16  Ziran Sun  <zsun@igalia.com>
+
+        [css-ui] alias appearance <compat-auto> keywords to 'auto' for textfield
+        https://bugs.webkit.org/show_bug.cgi?id=238551
+
+        Reviewed by Tim Nguyen.
+
+        This is to add support of aliasing appearance to 'auto' for textfield.
+        It has improved the following wpt tests
+        imported/w3c/web-platform-tests/css/css-ui/appearance-textfield-001.html
+        and
+        imported/w3c/web-platform-tests/css/css-ui/webkit-appearance-textfield-001.html.
+
+        The test failures though, are not fully fixed. The issue left is that the search cancel button
+        for input type="search" still present while it is expected to disappear (Bug 238751).
+
+        * rendering/RenderTheme.cpp:
+        (WebCore::RenderTheme::adjustAppearanceForElement const):
+
 2022-05-16  Loïc Le Page  <llepage@igalia.com>
 
         REGRESSION(r294104): [GStreamer][VideoCapture] Webcam raw streams may hang up the video capture pipeline

Source/WebCore/rendering/RenderTheme.cpp

@@ -117,6 +117,13 @@ ControlPart RenderTheme::adjustAppearanceForElement(RenderStyle& style, const El
         return autoAppearance;
     }
 
+    if (part == TextFieldPart) {
+        if (is<HTMLInputElement>(*element) && downcast<HTMLInputElement>(*element).isSearchField())
+            return part;
+        style.setEffectiveAppearance(autoAppearance);
+        return autoAppearance;
+    }
+
     return part;
 }