Skip to content
Permalink
Browse files
[WebRTC] Simplify libwebtc Xcode project
<https://webkit.org/b/232044>
<rdar://problem/82743710>

Reviewed by Youenn Fablet.

* Configurations/libwebm.xcconfig:
(INSTALL_HEADERS_PATH):
(LIBWEBM_HEADERS_FOLDER_PATH):
(LIBWEBM_HEADERS_FOLDER_PATH_NO):
(LIBWEBM_HEADERS_FOLDER_PATH_YES):
- Remove variables used by now-removed build phase scripts.
(PUBLIC_HEADERS_FOLDER_PATH): Add.
- This determines where webm public headers are installed.

* libwebrtc.xcodeproj/project.pbxproj:
(Recovered References): Remove.
- The two source files were added back at the correct path
  elsewhere, so these references can be removed.
(webm target):
- Remove "Copy webm headers" and "Copy common headers" build
  phase scripts since headers are installed by Xcode's built-in
  "Headers" phase.
- Remove duplicate C++ source files (noticed after reviewing
  "Recovered References" files).
- Install webm headers as public headers since their is no
  subdirectory structure, and this fixes the bug in the radar
  where webm headers were not installed consistently.


Canonical link: https://commits.webkit.org/243328@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@284599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
David Kilzer committed Oct 21, 2021
1 parent 4d617b6 commit a967556ff1c32dae66506cc441c09a2ac2fbbb7f
Show file tree
Hide file tree
Showing 3 changed files with 53 additions and 86 deletions.
@@ -1,3 +1,34 @@
2021-10-21 David Kilzer <ddkilzer@apple.com>

[WebRTC] Simplify libwebtc Xcode project
<https://webkit.org/b/232044>
<rdar://problem/82743710>

Reviewed by Youenn Fablet.

* Configurations/libwebm.xcconfig:
(INSTALL_HEADERS_PATH):
(LIBWEBM_HEADERS_FOLDER_PATH):
(LIBWEBM_HEADERS_FOLDER_PATH_NO):
(LIBWEBM_HEADERS_FOLDER_PATH_YES):
- Remove variables used by now-removed build phase scripts.
(PUBLIC_HEADERS_FOLDER_PATH): Add.
- This determines where webm public headers are installed.

* libwebrtc.xcodeproj/project.pbxproj:
(Recovered References): Remove.
- The two source files were added back at the correct path
elsewhere, so these references can be removed.
(webm target):
- Remove "Copy webm headers" and "Copy common headers" build
phase scripts since headers are installed by Xcode's built-in
"Headers" phase.
- Remove duplicate C++ source files (noticed after reviewing
"Recovered References" files).
- Install webm headers as public headers since their is no
subdirectory structure, and this fixes the bug in the radar
where webm headers were not installed consistently.

2021-10-20 Youenn Fablet <youenn@apple.com>

WebRTC p2p call, VP9-SVC only low layer decoded on receiver side
@@ -8,9 +8,5 @@ GCC_WARN_64_TO_32_BIT_CONVERSION = NO;
HEADER_SEARCH_PATHS = Source/third_party/libwebm Source/third_party/libwebm/webm_parser Source/third_party/libwebm/webm_parser/include;

INSTALL_PATH = /usr/local/lib;
PUBLIC_HEADERS_FOLDER_PATH = /usr/local/include/webm;
USE_HEADERMAP = NO;

INSTALL_HEADERS_PATH = /usr/local/include;
LIBWEBM_HEADERS_FOLDER_PATH = $(LIBWEBM_HEADERS_FOLDER_PATH_$(DEPLOYMENT_LOCATION));
LIBWEBM_HEADERS_FOLDER_PATH_NO = $(BUILT_PRODUCTS_DIR)/$(INSTALL_HEADERS_PATH);
LIBWEBM_HEADERS_FOLDER_PATH_YES = $(INSTALL_HEADERS_PATH);

0 comments on commit a967556

Please sign in to comment.