Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Remove declaration of unimplemented methods in LocaleICU
https://bugs.webkit.org/show_bug.cgi?id=154482

Patch by Olivier Blin <olivier.blin@softathome.com> on 2016-02-20
Reviewed by Michael Catanzaro.

detectSignAndGetDigitRange() and matchedDecimalSymbolIndex() are
implemented in PlatformLocale, not LocaleICU.

They were moved out from LocaleICU to NumberLocalizer in r124459
(2012), which has then been renamed as Localizer, then Locale, and
finally PlatformLocale.

* platform/text/LocaleICU.h:

Canonical link: https://commits.webkit.org/172602@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
blino authored and webkit-commit-queue committed Feb 20, 2016
1 parent b24dbb6 commit a9deaf5
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 3 deletions.
16 changes: 16 additions & 0 deletions Source/WebCore/ChangeLog
@@ -1,3 +1,19 @@
2016-02-20 Olivier Blin <olivier.blin@softathome.com>

Remove declaration of unimplemented methods in LocaleICU
https://bugs.webkit.org/show_bug.cgi?id=154482

Reviewed by Michael Catanzaro.

detectSignAndGetDigitRange() and matchedDecimalSymbolIndex() are
implemented in PlatformLocale, not LocaleICU.

They were moved out from LocaleICU to NumberLocalizer in r124459
(2012), which has then been renamed as Localizer, then Locale, and
finally PlatformLocale.

* platform/text/LocaleICU.h:

2016-02-20 Commit Queue <commit-queue@webkit.org>

Unreviewed, rolling out r196837.
Expand Down
3 changes: 0 additions & 3 deletions Source/WebCore/platform/text/LocaleICU.h
Expand Up @@ -68,9 +68,6 @@ class LocaleICU : public Locale {
String decimalTextAttribute(UNumberFormatTextAttribute);
virtual void initializeLocaleData() override;

bool detectSignAndGetDigitRange(const String& input, bool& isNegative, unsigned& startIndex, unsigned& endIndex);
unsigned matchedDecimalSymbolIndex(const String& input, unsigned& position);

bool initializeShortDateFormat();
UDateFormat* openDateFormat(UDateFormatStyle timeStyle, UDateFormatStyle dateStyle) const;

Expand Down

0 comments on commit a9deaf5

Please sign in to comment.