Skip to content
Permalink
Browse files
Runtime disable poly proto because it may be a 3-4% Speedometer regre…
…ssion

https://bugs.webkit.org/show_bug.cgi?id=178192

Reviewed by JF Bastien.

Source/JavaScriptCore:

* runtime/Options.h:
* runtime/StructureInlines.h:
(JSC::Structure::shouldConvertToPolyProto):

Tools:

* Scripts/run-jsc-stress-tests:


Canonical link: https://commits.webkit.org/194451@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@223222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
saambarati committed Oct 12, 2017
1 parent 35e3a69 commit ad8fea0659ae84f81b8f750b4695966cf7e6d7c4
Showing 5 changed files with 30 additions and 6 deletions.
@@ -1,3 +1,14 @@
2017-10-11 Saam Barati <sbarati@apple.com>

Runtime disable poly proto because it may be a 3-4% Speedometer regression
https://bugs.webkit.org/show_bug.cgi?id=178192

Reviewed by JF Bastien.

* runtime/Options.h:
* runtime/StructureInlines.h:
(JSC::Structure::shouldConvertToPolyProto):

2017-10-11 Commit Queue <commit-queue@webkit.org>

Unreviewed, rolling out r223113 and r223121.
@@ -473,6 +473,7 @@ typedef const char* optionString;
v(bool, useCallICsForWebAssemblyToJSCalls, true, Normal, "If true, we will use CallLinkInfo to inline cache Wasm to JS calls.") \
v(bool, useObjectRestSpread, true, Normal, "If true, we will enable Object Rest/Spread feature.") \
v(bool, useArrayAllocationProfiling, true, Normal, "If true, we will use our normal array allocation profiling. If false, the allocation profile will always claim to be undecided.")\
v(bool, usePolyProto, false, Normal, "If true, we may convert allocations to generate poly proto structures.") \
v(bool, forcePolyProto, false, Normal, "If true, create_this will always create an object with a poly proto structure.")


@@ -447,6 +447,9 @@ ALWAYS_INLINE void Structure::setPropertyTable(VM& vm, PropertyTable* table)

ALWAYS_INLINE bool Structure::shouldConvertToPolyProto(const Structure* a, const Structure* b)
{
if (!Options::usePolyProto())
return false;

if (!a || !b)
return false;

@@ -1,3 +1,12 @@
2017-10-11 Saam Barati <sbarati@apple.com>

Runtime disable poly proto because it may be a 3-4% Speedometer regression
https://bugs.webkit.org/show_bug.cgi?id=178192

Reviewed by JF Bastien.

* Scripts/run-jsc-stress-tests:

2017-10-11 Youenn Fablet <youenn@apple.com>

Add API to clean CacheStorage data
@@ -451,13 +451,13 @@ $numFailures = 0
$numPasses = 0

# We force all tests to use a smaller (1.5M) stack so that stack overflow tests can run faster.
BASE_OPTIONS = ["--useFTLJIT=false", "--useFunctionDotArguments=true", "--validateExceptionChecks=true", "--maxPerThreadStackUsage=1572864"]
EAGER_OPTIONS = ["--thresholdForJITAfterWarmUp=10", "--thresholdForJITSoon=10", "--thresholdForOptimizeAfterWarmUp=20", "--thresholdForOptimizeAfterLongWarmUp=20", "--thresholdForOptimizeSoon=20", "--thresholdForFTLOptimizeAfterWarmUp=20", "--thresholdForFTLOptimizeSoon=20", "--maximumEvalCacheableSourceLength=150000", "--useEagerCodeBlockJettisonTiming=true"]
BASE_OPTIONS = ["--useFTLJIT=false", "--useFunctionDotArguments=true", "--validateExceptionChecks=true", "--maxPerThreadStackUsage=1572864", "--usePolyProto=true"]
EAGER_OPTIONS = ["--thresholdForJITAfterWarmUp=10", "--thresholdForJITSoon=10", "--thresholdForOptimizeAfterWarmUp=20", "--thresholdForOptimizeAfterLongWarmUp=20", "--thresholdForOptimizeSoon=20", "--thresholdForFTLOptimizeAfterWarmUp=20", "--thresholdForFTLOptimizeSoon=20", "--maximumEvalCacheableSourceLength=150000", "--useEagerCodeBlockJettisonTiming=true", "--usePolyProto=true"]
# NOTE: Tests rely on this using scribbleFreeCells.
NO_CJIT_OPTIONS = ["--useConcurrentJIT=false", "--thresholdForJITAfterWarmUp=100", "--scribbleFreeCells=true"]
B3O1_OPTIONS = ["--defaultB3OptLevel=1"]
FTL_OPTIONS = ["--useFTLJIT=true"]
PROBE_OSR_EXIT_OPTION = ["--useProbeOSRExit=true"]
NO_CJIT_OPTIONS = ["--useConcurrentJIT=false", "--thresholdForJITAfterWarmUp=100", "--scribbleFreeCells=true", "--usePolyProto=true"]
B3O1_OPTIONS = ["--defaultB3OptLevel=1", "--usePolyProto=true"]
FTL_OPTIONS = ["--useFTLJIT=true", "--usePolyProto=true"]
PROBE_OSR_EXIT_OPTION = ["--useProbeOSRExit=true", "--usePolyProto=true"]

require_relative "webkitruby/jsc-stress-test-writer-#{$testWriter}"

0 comments on commit ad8fea0

Please sign in to comment.