Skip to content
Permalink
Browse files
[css-ui] Remove support for *-level-indicator appearance values
https://bugs.webkit.org/show_bug.cgi?id=240446

Reviewed by Antti Koivisto.

These only were implemented on macOS to display stars, or other alternative types of progress on <meter> elements.

These were already removed in Chromium: https://codereview.chromium.org/1747763002
  - continuous-capacity-level-indicator
  - discrete-capacity-level-indicator
  - relevancy-level-indicator
  - rating-level-indicator

Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html

* LayoutTests/accessibility/accessibility-crash-setattribute.html:
* LayoutTests/editing/execCommand/crash-breaking-blockquote-with-list.html:
* LayoutTests/editing/selection/modify-by-lineboundary-toward-pseudo-element.html:
* LayoutTests/fast/block/float/float-list-changed-before-layout-crash.html:
* LayoutTests/fast/css/content/content-quotes-crash-with-details.html:
* LayoutTests/fast/dom/HTMLMeterElement/meter-appearances-capacity.html: Removed.
* LayoutTests/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
* LayoutTests/platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Removed.
* LayoutTests/platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Removed.
* LayoutTests/platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Removed.
* LayoutTests/platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Removed.
* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
* LayoutTests/platform/ios/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Removed.
* LayoutTests/platform/ios/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Removed.
* LayoutTests/platform/mac/TestExpectations:
* LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Removed.
* LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Removed.
* LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Removed.
* LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Removed.
* LayoutTests/platform/win/TestExpectations:
* LayoutTests/platform/win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Removed.
* LayoutTests/platform/win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Removed.
* LayoutTests/platform/win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Removed.
* LayoutTests/platform/win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Removed.
* LayoutTests/platform/wincairo/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Removed.
* LayoutTests/platform/wincairo/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Removed.
* LayoutTests/platform/wpe/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Removed.
* LayoutTests/platform/wpe/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Removed.
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/platform/ThemeTypes.cpp:
(WebCore::operator<<):
* Source/WebCore/platform/ThemeTypes.h:
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):
(WebCore::RenderTheme::isControlStyled const):
* Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::supportsMeter const):
(WebCore::RenderThemeMac::levelIndicatorFor const):
(WebCore::RenderThemeMac::levelIndicatorStyleFor const): Deleted.
* Source/WebCore/rendering/RenderThemeMac.h:

Canonical link: https://commits.webkit.org/250889@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
nt1m committed May 23, 2022
1 parent a8a565e commit ae855d07957707df6eee6d3bc54210b3f17bd79c
Showing 37 changed files with 24 additions and 2,216 deletions.
@@ -22,7 +22,7 @@
<div id="div">
<dl>
<canvas>aaa</canvas>
<img id="img" src="x" style="-webkit-appearance: relevancy-level-indicator;" onerror="eventhandler()"></img>
<img id="img" src="x" style="-webkit-appearance: meter;" onerror="eventhandler()"></img>
</dl>
</div>
</body>
@@ -3,7 +3,7 @@
<div id="description">This test assures that inserting a newline in a list nested in a blockquote doesn't crash.</div>
<div contenteditable="true" id="container">
<blockquote type="cite">
<ol><li style=" -webkit-appearance: relevancy-level-indicator" id="two">TwoTwo</li></ol>
<ol><li style=" -webkit-appearance: meter" id="two">TwoTwo</li></ol>
</blockquote>
</div>
<script>
@@ -1,7 +1,7 @@
<style>
:after, :before {
content: counter(a);
-webkit-appearance: discrete-capacity-level-indicator;
-webkit-appearance: meter;
}
</style>
<script>
@@ -11,7 +11,7 @@
display: inline-table;
}
#el2:nth-last-child(2n) {
-webkit-appearance:discrete-capacity-level-indicator;
-webkit-appearance:meter;
}
#el2 {
display: table-header-group;
@@ -20,7 +20,7 @@
visibility: collapse;
}
#el5:nth-last-child(2n) {
-webkit-appearance:discrete-capacity-level-indicator;
-webkit-appearance:meter;
}
#el5 {
display: table-header-group;
@@ -8,5 +8,5 @@
testRunner.dumpAsText();
document.body.offsetHeight;
summary.appendChild(span);
details.style.setProperty("-webkit-appearance", "relevancy-level-indicator");
details.style.setProperty("-webkit-appearance", "meter");
</script>

This file was deleted.

This file was deleted.

@@ -31,9 +31,9 @@ PASS -webkit-appearance: checkbox-container (invalid)
PASS -webkit-appearance: checkbox-label (invalid)
PASS -webkit-appearance: checkmenuitem (invalid)
PASS -webkit-appearance: color-well (invalid)
FAIL -webkit-appearance: continuous-capacity-level-indicator (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "continuous-capacity-level-indicator"
PASS -webkit-appearance: continuous-capacity-level-indicator (invalid)
PASS -webkit-appearance: default-button (invalid)
FAIL -webkit-appearance: discrete-capacity-level-indicator (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "discrete-capacity-level-indicator"
PASS -webkit-appearance: discrete-capacity-level-indicator (invalid)
PASS -webkit-appearance: dualbutton (invalid)
PASS -webkit-appearance: groupbox (invalid)
PASS -webkit-appearance: image-controls-button (invalid)
@@ -88,8 +88,8 @@ PASS -webkit-appearance: radio-label (invalid)
PASS -webkit-appearance: radiomenuitem (invalid)
PASS -webkit-appearance: range (invalid)
PASS -webkit-appearance: range-thumb (invalid)
FAIL -webkit-appearance: rating-level-indicator (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "rating-level-indicator"
FAIL -webkit-appearance: relevancy-level-indicator (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "relevancy-level-indicator"
PASS -webkit-appearance: rating-level-indicator (invalid)
PASS -webkit-appearance: relevancy-level-indicator (invalid)
PASS -webkit-appearance: resizer (invalid)
PASS -webkit-appearance: resizerpanel (invalid)
PASS -webkit-appearance: scale-horizontal (invalid)
@@ -194,9 +194,9 @@ PASS appearance: checkbox-container (invalid)
PASS appearance: checkbox-label (invalid)
PASS appearance: checkmenuitem (invalid)
PASS appearance: color-well (invalid)
FAIL appearance: continuous-capacity-level-indicator (invalid) assert_equals: style.appearance expected "" but got "continuous-capacity-level-indicator"
PASS appearance: continuous-capacity-level-indicator (invalid)
PASS appearance: default-button (invalid)
FAIL appearance: discrete-capacity-level-indicator (invalid) assert_equals: style.appearance expected "" but got "discrete-capacity-level-indicator"
PASS appearance: discrete-capacity-level-indicator (invalid)
PASS appearance: dualbutton (invalid)
PASS appearance: groupbox (invalid)
PASS appearance: image-controls-button (invalid)
@@ -251,8 +251,8 @@ PASS appearance: radio-label (invalid)
PASS appearance: radiomenuitem (invalid)
PASS appearance: range (invalid)
PASS appearance: range-thumb (invalid)
FAIL appearance: rating-level-indicator (invalid) assert_equals: style.appearance expected "" but got "rating-level-indicator"
FAIL appearance: relevancy-level-indicator (invalid) assert_equals: style.appearance expected "" but got "relevancy-level-indicator"
PASS appearance: rating-level-indicator (invalid)
PASS appearance: relevancy-level-indicator (invalid)
PASS appearance: resizer (invalid)
PASS appearance: resizerpanel (invalid)
PASS appearance: scale-horizontal (invalid)
Deleted file not rendered

0 comments on commit ae855d0

Please sign in to comment.