This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Regression(r277571) Call to SQLiteDatabase::turnOnIncrementalAutoVacu…
…um() from ITP fails https://bugs.webkit.org/show_bug.cgi?id=229886 <rdar://82581507> Reviewed by Alex Christensen. Before r277571, `lastError()` was getting called after the call to `statement->columnInt(0)` and *before* the call to `statement.finalize()`. After r277571, the call to `statement.finalize()` became implicit, and gets called when `statement` does out of scope. As a result, `lastError()` was getting called *after* the statement finalization instead of after. This is an issue because the code expects the last error to be for `statement->columnInt(0)` and thus expects SQLITE_ROW. I moved the `lastError()` call so that it now after between `statement->columnInt(0)` and the implicit statement finalization, like it used to. * platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::turnOnIncrementalAutoVacuum): Canonical link: https://commits.webkit.org/241334@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@282030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing 2 changed files with 26 additions and 7 deletions.