Skip to content
Permalink
Browse files
AX: [ATK] ARIA form role should be mapped to ATK_ROLE_LANDMARK; not A…
…TK_ROLE_FORM

https://bugs.webkit.org/show_bug.cgi?id=178137

Reviewed by Chris Fleizach.

Source/WebCore:

Expose the ARIA form role as ATK_ROLE_LANDMARK; continue to expose the HTML form
element as ATK_ROLE_FORM.

No new tests needed due to existing coverage. Update expectations for roles-exposed.html.

* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):

Tools:

Add handling for ATK_ROLE_LANDMARK resulting from the ARIA form role.

* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

LayoutTests:

* platform/gtk/accessibility/roles-exposed-expected.txt: Updated expectations.


Canonical link: https://commits.webkit.org/194388@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@223145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
joanmarie committed Oct 10, 2017
1 parent 1f82930 commit af44b5ad3d943f29574abc93ffd3e10e8375dcce
Showing 6 changed files with 43 additions and 1 deletion.
@@ -1,3 +1,12 @@
2017-10-10 Joanmarie Diggs <jdiggs@igalia.com>

AX: [ATK] ARIA form role should be mapped to ATK_ROLE_LANDMARK; not ATK_ROLE_FORM
https://bugs.webkit.org/show_bug.cgi?id=178137

Reviewed by Chris Fleizach.

* platform/gtk/accessibility/roles-exposed-expected.txt: Updated expectations.

2017-10-10 Matt Rajca <mrajca@apple.com>

Respect audio rate change restrictions in HTMLMediaElement::setVolume.
@@ -647,7 +647,7 @@ div[role=figure]
AXRole: AXGroup

div[role=form]
AXRole: AXForm
AXRole: AXLandmarkForm

div[role=grid]
AXRole: AXTable
@@ -1,3 +1,18 @@
2017-10-10 Joanmarie Diggs <jdiggs@igalia.com>

AX: [ATK] ARIA form role should be mapped to ATK_ROLE_LANDMARK; not ATK_ROLE_FORM
https://bugs.webkit.org/show_bug.cgi?id=178137

Reviewed by Chris Fleizach.

Expose the ARIA form role as ATK_ROLE_LANDMARK; continue to expose the HTML form
element as ATK_ROLE_FORM.

No new tests needed due to existing coverage. Update expectations for roles-exposed.html.

* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):

2017-10-10 Matt Rajca <mrajca@apple.com>

Respect audio rate change restrictions in HTMLMediaElement::setVolume.
@@ -773,6 +773,10 @@ static AtkRole atkRole(AccessibilityObject* coreObject)
case FooterRole:
return ATK_ROLE_FOOTER;
case FormRole:
#if ATK_CHECK_VERSION(2, 11, 3)
if (coreObject->ariaRoleAttribute() != UnknownRole)
return ATK_ROLE_LANDMARK;
#endif
return ATK_ROLE_FORM;
case CanvasRole:
return ATK_ROLE_CANVAS;
@@ -1,3 +1,14 @@
2017-10-10 Joanmarie Diggs <jdiggs@igalia.com>

AX: [ATK] ARIA form role should be mapped to ATK_ROLE_LANDMARK; not ATK_ROLE_FORM
https://bugs.webkit.org/show_bug.cgi?id=178137

Reviewed by Chris Fleizach.

Add handling for ATK_ROLE_LANDMARK resulting from the ARIA form role.

* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

2017-10-10 Jonathan Bedard <jbedard@apple.com>

run-webkit-tests: upload test results to multiple servers
@@ -125,6 +125,7 @@ const String attributesMap[][2] = {
const char* landmarkStringBanner = "AXLandmarkBanner";
const char* landmarkStringComplementary = "AXLandmarkComplementary";
const char* landmarkStringContentinfo = "AXLandmarkContentInfo";
const char* landmarkStringForm = "AXLandmarkForm";
const char* landmarkStringMain = "AXLandmarkMain";
const char* landmarkStringNavigation = "AXLandmarkNavigation";
const char* landmarkStringRegion = "AXLandmarkRegion";
@@ -394,6 +395,8 @@ const gchar* roleToString(AtkObject* object)
return landmarkStringRegion;
if (equalLettersIgnoringASCIICase(xmlRolesValue, "doc-toc"))
return landmarkStringRegion;
if (equalLettersIgnoringASCIICase(xmlRolesValue, "form"))
return landmarkStringForm;
if (equalLettersIgnoringASCIICase(xmlRolesValue, "main"))
return landmarkStringMain;
if (equalLettersIgnoringASCIICase(xmlRolesValue, "navigation"))

0 comments on commit af44b5a

Please sign in to comment.