Permalink
Show file tree
Hide file tree
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
SVG Animations update baseVal instead of animVal
https://bugs.webkit.org/show_bug.cgi?id=12437 Reviewed by Dirk Schulze. Blind fix for some GC related assertions firing on v8. Assure that animationStarted/animationEnded calls are happening on the same SVGAnimatedProperty. Always call animationEnded(), even if we shouldn't do anything for the target element, as its destructed, as we still have to reset m_isAnimating. * svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::SVGAnimateElement): (WebCore::SVGAnimateElement::resetToBaseValue): (WebCore::SVGAnimateElement::targetElementWillChange): * svg/SVGAnimateElement.h: (SVGAnimateElement): * svg/properties/SVGAnimatedPropertyTearOff.h: (WebCore::SVGAnimatedPropertyTearOff::animationEnded): Canonical link: https://commits.webkit.org/98168@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Nikolas Zimmermann
committed
Mar 13, 2012
1 parent
c00a66a
commit b01d8a7cd8e1cbe9f896e4b34ea52b3d1e762554
Showing
4 changed files
with
42 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters