Skip to content
Permalink
Browse files
Document.URL / Document.documentURI should return "about:blank" inste…
…ad of empty string / null

https://bugs.webkit.org/show_bug.cgi?id=153363
<rdar://problem/22549736>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline several W3C tests now that more checks are passing.

* web-platform-tests/dom/interfaces-expected.txt:
* web-platform-tests/dom/nodes/DOMImplementation-createDocument-expected.txt:
* web-platform-tests/dom/nodes/DOMImplementation-createHTMLDocument-expected.txt:
* web-platform-tests/dom/nodes/Document-constructor-expected.txt:
* web-platform-tests/dom/nodes/Node-properties-expected.txt:
* web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

Document.URL / Document.documentURI should return "about:blank" instead
of empty string / null, as per the specification:
- https://dom.spec.whatwg.org/#dom-document-url
- https://dom.spec.whatwg.org/#concept-document-url

Also, Document.documentURI should be an alias for Document.URL as per:
- https://dom.spec.whatwg.org/#dom-document-url

Firefox matches the specification.

No new tests, already covered by existing W3C tests.

* dom/Document.h:
(WebCore::Document::urlForBindings):
* dom/Document.idl:

LayoutTests:

Drop outdated tests.

* dom/xhtml/level3/core/documentgetdocumenturi02-expected.txt: Removed.
* dom/xhtml/level3/core/documentgetdocumenturi02.js: Removed.
* dom/xhtml/level3/core/documentgetdocumenturi02.xhtml: Removed.
* dom/xhtml/level3/core/documentgetdocumenturi03-expected.txt: Removed.
* dom/xhtml/level3/core/documentgetdocumenturi03.js: Removed.
* dom/xhtml/level3/core/documentgetdocumenturi03.xhtml: Removed.
* dom/xhtml/level3/core/documentsetdocumenturi03-expected.txt: Removed.
* dom/xhtml/level3/core/documentsetdocumenturi03.js: Removed.
* dom/xhtml/level3/core/documentsetdocumenturi03.xhtml: Removed.
* fast/dom/document-attribute-js-null-expected.txt:
* fast/dom/document-attribute-js-null.html:


Canonical link: https://commits.webkit.org/171448@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@195485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
cdumez committed Jan 22, 2016
1 parent c143d94 commit b210b534b513619eacb486382eebd7c242da596c
Show file tree
Hide file tree
Showing 22 changed files with 153 additions and 643 deletions.
@@ -1,3 +1,25 @@
2016-01-22 Chris Dumez <cdumez@apple.com>

Document.URL / Document.documentURI should return "about:blank" instead of empty string / null
https://bugs.webkit.org/show_bug.cgi?id=153363
<rdar://problem/22549736>

Reviewed by Ryosuke Niwa.

Drop outdated tests.

* dom/xhtml/level3/core/documentgetdocumenturi02-expected.txt: Removed.
* dom/xhtml/level3/core/documentgetdocumenturi02.js: Removed.
* dom/xhtml/level3/core/documentgetdocumenturi02.xhtml: Removed.
* dom/xhtml/level3/core/documentgetdocumenturi03-expected.txt: Removed.
* dom/xhtml/level3/core/documentgetdocumenturi03.js: Removed.
* dom/xhtml/level3/core/documentgetdocumenturi03.xhtml: Removed.
* dom/xhtml/level3/core/documentsetdocumenturi03-expected.txt: Removed.
* dom/xhtml/level3/core/documentsetdocumenturi03.js: Removed.
* dom/xhtml/level3/core/documentsetdocumenturi03.xhtml: Removed.
* fast/dom/document-attribute-js-null-expected.txt:
* fast/dom/document-attribute-js-null.html:

2016-01-22 Tim Horton <timothy_horton@apple.com>

Add a test for iOS arrow-key repeat

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

0 comments on commit b210b53

Please sign in to comment.