Skip to content
Permalink
Browse files
Enable OffscreenCanvas in workers, start running layout tests, and en…
…able it for cocoa.

https://bugs.webkit.org/show_bug.cgi?id=247107

Reviewed by Dean Jackson.

* LayoutTests/TestExpectations:
* LayoutTests/http/wpt/offscreen-canvas/getContext-webgl-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/compositing/2d.composite.globalAlpha.canvascopy-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/compositing/2d.composite.globalAlpha.canvascopy.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/drawing-images-to-the-canvas/2d.drawImage.zerosource-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.CSSHSL-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic.negative.rotation-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic.negative.rotation.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic.positive.rotation-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic.positive.rotation.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.radial.cone.bottom-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.radial.cone.bottom.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.radial.cone.cylinder-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.radial.cone.cylinder.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.radial.cone.front-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.radial.cone.front.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.radial.cone.shape1-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.radial.cone.shape1.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.radial.cone.top-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.radial.cone.top.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.radial.inside1-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.radial.inside1.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.radial.inside2-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.radial.inside2.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.radial.inside3-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.radial.inside3.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.radial.outside1-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.radial.outside1.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.radial.outside2-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.radial.outside2.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.radial.outside3-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.radial.outside3.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.radial.touch2-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.radial.touch2.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/filter/offscreencanvas.filter.w-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/image-smoothing/image.smoothing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/image-smoothing/image.smoothing.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/filter/offscreencanvas.filter.w-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/image-smoothing/image.smoothing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/image-smoothing/image.smoothing.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.commit-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.getcontext-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.getcontext.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.resize-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.transfer.to.imagebitmap-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.transferrable-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/manual/wide-gamut-canvas/2d.color.space.p3.convertToBlobp3.canvas-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.rect.winding-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/path-objects/2d.path.rect.winding.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.draw.baseline.ideographic-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.draw.baseline.ideographic.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.measure.actualBoundingBox-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/text/2d.text.measure.actualBoundingBox.worker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/wide-gamut-canvas/2d.color.space.p3.to.p3-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/wide-gamut-canvas/2d.color.space.p3.to.p3.worker-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/wide-gamut-canvas/2d.color.space.p3.to.srgb-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/canvas/offscreen/wide-gamut-canvas/2d.color.space.p3.to.srgb.worker-expected.txt: Added.
* LayoutTests/platform/mac/imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.gradient.conic.worker-expected.png: Added.
* LayoutTests/platform/win/TestExpectations:
* Source/WTF/wtf/PlatformEnableCocoa.h:

Canonical link: https://commits.webkit.org/257672@main
  • Loading branch information
mattwoodrow committed Dec 10, 2022
1 parent 88ffca6 commit b32d7b9f1487e0c5bcd836a8dda7cc5fc44485a6
Show file tree
Hide file tree
Showing 145 changed files with 655 additions and 527 deletions.
@@ -1250,10 +1250,9 @@ http/tests/websocket/tests/hybi/imported/blink/permessage-deflate-split-frames.h
http/tests/websocket/tests/hybi/imported/blink/permessage-deflate-unsolicited-negotiation-response.html [ Skip ]
http/tests/websocket/tests/hybi/imported/blink/permessage-deflate-window-bits.html [ Skip ]

# OffscreenCanvas is only enabled on GTK and WPE by default
webkit.org/b/203146 fast/canvas/offscreen-enabled.html [ Skip ]
webkit.org/b/203146 http/wpt/offscreen-canvas [ Skip ]
webkit.org/b/203146 imported/w3c/web-platform-tests/html/canvas/offscreen [ Skip ]
http/wpt/offscreen-canvas/transferToImageBitmap-webgl.html [ Failure ]
imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.commit.html [ Failure Pass ]
imported/w3c/web-platform-tests/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.resize.html [ Failure Pass ]

# Tests a setting behind the ENABLE_FULLSCREEN_API flag, which is WK2-only
media/video-supports-fullscreen.html [ Skip ]
@@ -1,3 +1,3 @@

PASS Test getContext('webgl').
FAIL Test getContext('webgl'). assert_true: expected true got false

@@ -1,5 +1,5 @@
2d.composite.globalAlpha.canvascopy


FAIL OffscreenCanvas test: 2d.composite.globalAlpha.canvascopy assert_approx_equals: Red channel of the pixel at (50, 25) expected 0 +/- 2 but got 125
PASS OffscreenCanvas test: 2d.composite.globalAlpha.canvascopy

@@ -1,3 +1,3 @@

FAIL 2d assert_approx_equals: Red channel of the pixel at (50, 25) expected 0 +/- 2 but got 125
PASS 2d

@@ -1,7 +1,7 @@
2d.drawImage.zerosource

drawImage with zero-sized source rectangle throws INDEX_SIZE_ERR
drawImage with zero-sized source rectangle draws nothing without exception


PASS drawImage with zero-sized source rectangle throws INDEX_SIZE_ERR
PASS drawImage with zero-sized source rectangle draws nothing without exception

@@ -3,5 +3,5 @@
CSSHSL works as color input


FAIL CSSHSL works as color input Can't find variable: CSSHSL
FAIL CSSHSL works as color input assert_approx_equals: Red channel of the pixel at (50, 25) expected 64 +/- 3 but got 0

@@ -3,5 +3,5 @@
Conic gradient with negative rotation


FAIL Conic gradient with negative rotation assert_equals: Red channel of the pixel at (25, 15) expected 255 but got 196
FAIL Conic gradient with negative rotation assert_equals: Green channel of the pixel at (75, 40) expected 255 but got 254

@@ -1,3 +1,3 @@

FAIL Conic gradient with negative rotation assert_equals: Red channel of the pixel at (25, 15) expected 255 but got 196
FAIL Conic gradient with negative rotation assert_equals: Green channel of the pixel at (75, 40) expected 255 but got 254

@@ -3,5 +3,5 @@
Conic gradient with positive rotation


FAIL Conic gradient with positive rotation assert_equals: Red channel of the pixel at (25, 15) expected 255 but got 196
FAIL Conic gradient with positive rotation assert_equals: Green channel of the pixel at (75, 40) expected 255 but got 254

@@ -1,3 +1,3 @@

FAIL Conic gradient with positive rotation assert_equals: Red channel of the pixel at (25, 15) expected 255 but got 196
FAIL Conic gradient with positive rotation assert_equals: Green channel of the pixel at (75, 40) expected 255 but got 254

@@ -1,3 +1,8 @@

FAIL Conic gradient function exists ctx.createConicGradient is not a function. (In 'ctx.createConicGradient(0, 0, 25)', 'ctx.createConicGradient' is undefined)

layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
layer at (0,0) size 800x41
RenderBlock {HTML} at (0,0) size 800x41
RenderBody {BODY} at (8,13) size 784x15
RenderBlock {PRE} at (0,0) size 784x15
RenderText {#text} at (0,0) size 328x15
text run at (0,0) width 328: "{\"error\": {\"code\": 404, \"message\": \"404\"}}"
@@ -1,5 +1,5 @@
2d.gradient.radial.cone.bottom


PASS OffscreenCanvas test: 2d.gradient.radial.cone.bottom
FAIL OffscreenCanvas test: 2d.gradient.radial.cone.bottom assert_equals: Green channel of the pixel at (98, 25) expected 255 but got 254

@@ -1,3 +1,3 @@

PASS 2d
FAIL 2d assert_equals: Green channel of the pixel at (98, 25) expected 255 but got 254

@@ -1,5 +1,5 @@
2d.gradient.radial.cone.cylinder


PASS OffscreenCanvas test: 2d.gradient.radial.cone.cylinder
FAIL OffscreenCanvas test: 2d.gradient.radial.cone.cylinder assert_equals: Green channel of the pixel at (98, 25) expected 255 but got 254

@@ -1,3 +1,3 @@

PASS 2d
FAIL 2d assert_equals: Green channel of the pixel at (98, 25) expected 255 but got 254

@@ -1,5 +1,5 @@
2d.gradient.radial.cone.front


PASS OffscreenCanvas test: 2d.gradient.radial.cone.front
FAIL OffscreenCanvas test: 2d.gradient.radial.cone.front assert_equals: Green channel of the pixel at (98, 25) expected 255 but got 254

@@ -1,3 +1,3 @@

PASS 2d
FAIL 2d assert_equals: Green channel of the pixel at (98, 25) expected 255 but got 254

@@ -1,5 +1,5 @@
2d.gradient.radial.cone.shape1


PASS OffscreenCanvas test: 2d.gradient.radial.cone.shape1
FAIL OffscreenCanvas test: 2d.gradient.radial.cone.shape1 assert_equals: Green channel of the pixel at (98, 25) expected 255 but got 254

@@ -1,3 +1,3 @@

PASS 2d
FAIL 2d assert_equals: Green channel of the pixel at (98, 25) expected 255 but got 254

@@ -1,5 +1,5 @@
2d.gradient.radial.cone.top


PASS OffscreenCanvas test: 2d.gradient.radial.cone.top
FAIL OffscreenCanvas test: 2d.gradient.radial.cone.top assert_equals: Green channel of the pixel at (98, 25) expected 255 but got 254

@@ -1,3 +1,3 @@

PASS 2d
FAIL 2d assert_equals: Green channel of the pixel at (98, 25) expected 255 but got 254

@@ -1,5 +1,5 @@
2d.gradient.radial.inside1


PASS OffscreenCanvas test: 2d.gradient.radial.inside1
FAIL OffscreenCanvas test: 2d.gradient.radial.inside1 assert_equals: Green channel of the pixel at (98, 25) expected 255 but got 254

@@ -1,3 +1,3 @@

PASS 2d
FAIL 2d assert_equals: Green channel of the pixel at (98, 25) expected 255 but got 254

@@ -1,5 +1,5 @@
2d.gradient.radial.inside2


PASS OffscreenCanvas test: 2d.gradient.radial.inside2
FAIL OffscreenCanvas test: 2d.gradient.radial.inside2 assert_equals: Green channel of the pixel at (98, 25) expected 255 but got 254

@@ -1,3 +1,3 @@

PASS 2d
FAIL 2d assert_equals: Green channel of the pixel at (98, 25) expected 255 but got 254

@@ -1,5 +1,5 @@
2d.gradient.radial.inside3


PASS OffscreenCanvas test: 2d.gradient.radial.inside3
FAIL OffscreenCanvas test: 2d.gradient.radial.inside3 assert_equals: Green channel of the pixel at (98, 25) expected 255 but got 254

@@ -1,3 +1,3 @@

PASS 2d
FAIL 2d assert_equals: Green channel of the pixel at (98, 25) expected 255 but got 254

@@ -1,5 +1,5 @@
2d.gradient.radial.outside1


PASS OffscreenCanvas test: 2d.gradient.radial.outside1
FAIL OffscreenCanvas test: 2d.gradient.radial.outside1 assert_equals: Green channel of the pixel at (98, 25) expected 255 but got 254

@@ -1,3 +1,3 @@

PASS 2d
FAIL 2d assert_equals: Green channel of the pixel at (98, 25) expected 255 but got 254

@@ -1,5 +1,5 @@
2d.gradient.radial.outside2


PASS OffscreenCanvas test: 2d.gradient.radial.outside2
FAIL OffscreenCanvas test: 2d.gradient.radial.outside2 assert_equals: Green channel of the pixel at (98, 25) expected 255 but got 254

@@ -1,3 +1,3 @@

PASS 2d
FAIL 2d assert_equals: Green channel of the pixel at (98, 25) expected 255 but got 254

@@ -1,5 +1,5 @@
2d.gradient.radial.outside3


PASS OffscreenCanvas test: 2d.gradient.radial.outside3
FAIL OffscreenCanvas test: 2d.gradient.radial.outside3 assert_equals: Green channel of the pixel at (98, 25) expected 255 but got 254