Skip to content
Permalink
Browse files
Speedometer: Make React/Redux item order consistent
https://bugs.webkit.org/show_bug.cgi?id=175818

Reviewed by Joseph Pecoraro.

Based on the patch made by Mathias Bynens. Re-generated project files.

Also tweaked the instruction in package.json so that newly generated files in build/* replace dist/* instead of
being moved under dist/build/ by rm -rf'ing dist directory first.

* Speedometer/resources/todomvc/architecture-examples/react-redux/dist/index.html:
* Speedometer/resources/todomvc/architecture-examples/react-redux/dist/static/js/main.43a0948c.js: Removed.
* Speedometer/resources/todomvc/architecture-examples/react-redux/dist/static/js/main.43a0948c.js.map: Removed.
* Speedometer/resources/todomvc/architecture-examples/react-redux/dist/static/js/main.69cd9655.js: Added.
* Speedometer/resources/todomvc/architecture-examples/react-redux/dist/static/js/main.69cd9655.js.map: Added.
* Speedometer/resources/todomvc/architecture-examples/react-redux/package.json:
* Speedometer/resources/todomvc/architecture-examples/react-redux/src/reducers/todos.js: Forced new items to be appended rather than prepended.
* Speedometer/resources/todomvc/architecture-examples/react-redux/yarn.lock: Removed unnecessary file.


Canonical link: https://commits.webkit.org/192559@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
rniwa committed Aug 23, 2017
1 parent fdc8266 commit b4bd9a029bf08c7dca37839ebc4772aae3ce06c1
@@ -1,3 +1,24 @@
2017-08-23 Ryosuke Niwa <rniwa@webkit.org>

Speedometer: Make React/Redux item order consistent
https://bugs.webkit.org/show_bug.cgi?id=175818

Reviewed by Joseph Pecoraro.

Based on the patch made by Mathias Bynens. Re-generated project files.

Also tweaked the instruction in package.json so that newly generated files in build/* replace dist/* instead of
being moved under dist/build/ by rm -rf'ing dist directory first.

* Speedometer/resources/todomvc/architecture-examples/react-redux/dist/index.html:
* Speedometer/resources/todomvc/architecture-examples/react-redux/dist/static/js/main.43a0948c.js: Removed.
* Speedometer/resources/todomvc/architecture-examples/react-redux/dist/static/js/main.43a0948c.js.map: Removed.
* Speedometer/resources/todomvc/architecture-examples/react-redux/dist/static/js/main.69cd9655.js: Added.
* Speedometer/resources/todomvc/architecture-examples/react-redux/dist/static/js/main.69cd9655.js.map: Added.
* Speedometer/resources/todomvc/architecture-examples/react-redux/package.json:
* Speedometer/resources/todomvc/architecture-examples/react-redux/src/reducers/todos.js: Forced new items to be appended rather than prepended.
* Speedometer/resources/todomvc/architecture-examples/react-redux/yarn.lock: Removed unnecessary file.

2017-08-23 Mathias Bynens <mathias@qiwi.be>

Speedometer: Update to modern React version
@@ -1 +1 @@
<!DOCTYPE html><html lang="en"><head><meta charset="utf-8"><meta name="viewport" content="width=device-width,initial-scale=1"><title>React Redux TodoMVC example</title><link href="./static/css/main.f04a7319.css" rel="stylesheet"></head><body><div class="todoapp" id="root"></div><script type="text/javascript" src="./static/js/main.43a0948c.js"></script></body></html>
<!DOCTYPE html><html lang="en"><head><meta charset="utf-8"><meta name="viewport" content="width=device-width,initial-scale=1"><title>React Redux TodoMVC example</title><link href="./static/css/main.f04a7319.css" rel="stylesheet"></head><body><div class="todoapp" id="root"></div><script type="text/javascript" src="./static/js/main.69cd9655.js"></script></body></html>

This file was deleted.

This file was deleted.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

@@ -15,7 +15,7 @@
},
"scripts": {
"start": "react-scripts start",
"build": "react-scripts build && mv build dist",
"build": "rm -rf dist && react-scripts build && mv build dist",
"test": "react-scripts test"
},
"homepage": "./"
@@ -6,12 +6,12 @@ export default function todos(state = initialState, action) {
switch (action.type) {
case ADD_TODO:
return [
...state,
{
id: state.reduce((maxId, todo) => Math.max(todo.id, maxId), -1) + 1,
completed: false,
text: action.text
},
...state
}
]

case DELETE_TODO:

0 comments on commit b4bd9a0

Please sign in to comment.