Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Unreviewed, build fix after r241954
https://bugs.webkit.org/show_bug.cgi?id=194939

Renaming setCanAccessHeap was incomplete.

* runtime/SmallStrings.cpp:
(JSC::SmallStrings::initializeCommonStrings):
* runtime/VM.cpp:
(JSC::VM::~VM):

Canonical link: https://commits.webkit.org/209314@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@241955 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Constellation committed Feb 22, 2019
1 parent e4fc3ca commit b539eee
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 2 deletions.
12 changes: 12 additions & 0 deletions Source/JavaScriptCore/ChangeLog
@@ -1,3 +1,15 @@
2019-02-22 Yusuke Suzuki <ysuzuki@apple.com>

Unreviewed, build fix after r241954
https://bugs.webkit.org/show_bug.cgi?id=194939

Renaming setCanAccessHeap was incomplete.

* runtime/SmallStrings.cpp:
(JSC::SmallStrings::initializeCommonStrings):
* runtime/VM.cpp:
(JSC::VM::~VM):

2019-02-22 Yusuke Suzuki <ysuzuki@apple.com>

[JSC] SmallStringsStorage is unnecessary
Expand Down
2 changes: 1 addition & 1 deletion Source/JavaScriptCore/runtime/SmallStrings.cpp
Expand Up @@ -60,7 +60,7 @@ void SmallStrings::initializeCommonStrings(VM& vm)
initialize(&vm, m_nullObjectString, "[object Null]");
initialize(&vm, m_undefinedObjectString, "[object Undefined]");

setInitialized(true);
setIsInitialized(true);
}

void SmallStrings::visitStrongReferences(SlotVisitor& visitor)
Expand Down
2 changes: 1 addition & 1 deletion Source/JavaScriptCore/runtime/VM.cpp
Expand Up @@ -540,7 +540,7 @@ VM::~VM()

ASSERT(currentThreadIsHoldingAPILock());
m_apiLock->willDestroyVM(this);
smallStrings.setInitialized(false);
smallStrings.setIsInitialized(false);
heap.lastChanceToFinalize();

JSRunLoopTimer::Manager::shared().unregisterVM(*this);
Expand Down

0 comments on commit b539eee

Please sign in to comment.