Skip to content
Permalink
Browse files
Full screen from an iframe with a z-index style will allow siblings w…
…ith higher z-index to overlay full screen content.

https://bugs.webkit.org/show_bug.cgi?id=111637

Reviewed by Simon Fraser.

Source/WebCore:

No new tests; updated fullscreen/full-screen-iframe-zIndex.html to expose bug.

Pages with explicit z-index: styles on their iframes will override the default z-index: UA style when
elements within that iframe enter full screen mode. Mark the UA style as !important so as to not allow
iframe siblings with higher z-index styles to overlay the full screen element.

* css/fullscreen.css:
(:-webkit-full-screen):

LayoutTests:

* fullscreen/full-screen-iframe-zIndex.html:


Canonical link: https://commits.webkit.org/130009@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
jernoble committed Mar 7, 2013
1 parent fc2cf77 commit b6672038bd0a877bc857fcdda27e2b055a95e6c1
Showing 4 changed files with 27 additions and 1 deletion.
@@ -1,3 +1,12 @@
2013-03-06 Jer Noble <jer.noble@apple.com>

Full screen from an iframe with a z-index style will allow siblings with higher z-index to overlay full screen content.
https://bugs.webkit.org/show_bug.cgi?id=111637

Reviewed by Simon Fraser.

* fullscreen/full-screen-iframe-zIndex.html:

2013-03-06 Ryosuke Niwa <rniwa@webkit.org>

editing/pasteboard/paste-4035648-fix.html should be a dump-as-markup test
@@ -30,6 +30,7 @@
height: 100px;
border: 4px solid darkgreen;
background-color: green;
z-index: 0;
}
#block2 {
width: 100px;
@@ -1,3 +1,19 @@
2013-03-06 Jer Noble <jer.noble@apple.com>

Full screen from an iframe with a z-index style will allow siblings with higher z-index to overlay full screen content.
https://bugs.webkit.org/show_bug.cgi?id=111637

Reviewed by Simon Fraser.

No new tests; updated fullscreen/full-screen-iframe-zIndex.html to expose bug.

Pages with explicit z-index: styles on their iframes will override the default z-index: UA style when
elements within that iframe enter full screen mode. Mark the UA style as !important so as to not allow
iframe siblings with higher z-index styles to overlay the full screen element.

* css/fullscreen.css:
(:-webkit-full-screen):

2013-03-06 Levi Weintraub <leviw@chromium.org>

InsertUnorderedList can lead to lost content and assertions in moveParagraphs
@@ -1,6 +1,6 @@
:-webkit-full-screen {
background-color: white;
z-index: 2147483647;
z-index: 2147483647 !important;
}

:root:-webkit-full-screen-document:not(:-webkit-full-screen), :root:-webkit-full-screen-ancestor {

0 comments on commit b667203

Please sign in to comment.