Skip to content
Permalink
Browse files
JSContext Inspector: Broken frontend, DOMAgent is used but does not e…
…xist

https://bugs.webkit.org/show_bug.cgi?id=190922
<rdar://problem/45569827>

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2018-10-25
Reviewed by Devin Rousso.

* UserInterface/Controllers/DOMManager.js:
(WI.DOMManager.prototype.requestDocument):
Feature check for agents that may not exist in a JSContext.

Canonical link: https://commits.webkit.org/205773@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237435 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
JosephPecoraro authored and webkit-commit-queue committed Oct 25, 2018
1 parent 1b8a980 commit b6a1df675c5e9d590fe83eeb5fadfeb7bbfa5e54
Showing with 14 additions and 1 deletion.
  1. +12 −0 Source/WebInspectorUI/ChangeLog
  2. +2 −1 Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js
@@ -1,3 +1,15 @@
2018-10-25 Joseph Pecoraro <pecoraro@apple.com>

JSContext Inspector: Broken frontend, DOMAgent is used but does not exist
https://bugs.webkit.org/show_bug.cgi?id=190922
<rdar://problem/45569827>

Reviewed by Devin Rousso.

* UserInterface/Controllers/DOMManager.js:
(WI.DOMManager.prototype.requestDocument):
Feature check for agents that may not exist in a JSContext.

2018-10-25 Devin Rousso <drousso@apple.com>

Web Inspector: add corner rounding to the network timing "blocks"
@@ -82,7 +82,8 @@ WI.DOMManager = class DOMManager extends WI.Object
this._pendingDocumentRequestCallbacks = null;
}

DOMAgent.getDocument(onDocumentAvailable.bind(this));
if (window.DOMAgent)
DOMAgent.getDocument(onDocumentAvailable.bind(this));
}

ensureDocument()

0 comments on commit b6a1df6

Please sign in to comment.