Skip to content
Permalink
Browse files
Allow OjbC Weak References when building TestAPI
https://bugs.webkit.org/show_bug.cgi?id=178748

Reviewed by Dan Bernstein.

Set TestAPI build flag Weak References in Manual Retain Release to true.

* JavaScriptCore.xcodeproj/project.pbxproj: Reverted.
* Configurations/ToolExecutable.xcconfig: Changed the flag here instead.


Canonical link: https://commits.webkit.org/194933@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@223937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
msaboff committed Oct 24, 2017
1 parent dcca09a commit b7b931b8acb23e0a2f22b71b95840e432571cdb1
Showing 3 changed files with 14 additions and 4 deletions.
@@ -1,3 +1,15 @@
2017-10-24 Michael Saboff <msaboff@apple.com>

Allow OjbC Weak References when building TestAPI
https://bugs.webkit.org/show_bug.cgi?id=178748

Reviewed by Dan Bernstein.

Set TestAPI build flag Weak References in Manual Retain Release to true.

* JavaScriptCore.xcodeproj/project.pbxproj: Reverted.
* Configurations/ToolExecutable.xcconfig: Changed the flag here instead.

2017-10-24 Eric Carlson <eric.carlson@apple.com>

Web Inspector: Enable WebKit logging configuration and display
@@ -51,6 +51,8 @@ CLANG_ENABLE_OBJC_ARC_armv7s = YES;
CLANG_ENABLE_OBJC_ARC_arm64 = YES;
CLANG_ENABLE_OBJC_ARC_arm64e = YES;

CLANG_ENABLE_OBJC_WEAK = YES;

OTHER_CFLAGS = $(ASAN_OTHER_CFLAGS) -isystem icu;
OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS);

@@ -10383,23 +10383,20 @@
isa = XCBuildConfiguration;
baseConfigurationReference = BC021BF2136900C300FC5467 /* ToolExecutable.xcconfig */;
buildSettings = {
CLANG_ENABLE_OBJC_WEAK = YES;
};
name = Debug;
};
14BD59D80A3E8FC900BAF59C /* Release */ = {
isa = XCBuildConfiguration;
baseConfigurationReference = BC021BF2136900C300FC5467 /* ToolExecutable.xcconfig */;
buildSettings = {
CLANG_ENABLE_OBJC_WEAK = YES;
};
name = Release;
};
14BD59D90A3E8FC900BAF59C /* Production */ = {
isa = XCBuildConfiguration;
baseConfigurationReference = BC021BF2136900C300FC5467 /* ToolExecutable.xcconfig */;
buildSettings = {
CLANG_ENABLE_OBJC_WEAK = YES;
};
name = Production;
};
@@ -10588,7 +10585,6 @@
isa = XCBuildConfiguration;
baseConfigurationReference = BC021BF2136900C300FC5467 /* ToolExecutable.xcconfig */;
buildSettings = {
CLANG_ENABLE_OBJC_WEAK = YES;
};
name = Profiling;
};

0 comments on commit b7b931b

Please sign in to comment.