Cannot animate "points" attribute for <svg:polygon>

https://bugs.webkit.org/show_bug.cgi?id=21371

Reviewed by Antti Koivisto.

Source/WebCore:

Ensure we use animated list of points for SVG <polygon> and <polyline> elements
when we build the path used to draw them, otherwise the animated changes won't
be rendered and the base value will be used.

Tests: svg/animations/polygon-set.svg
       svg/animations/polyline-set.svg

* rendering/svg/SVGPathData.cpp:
(WebCore::updatePathFromPolygonElement):
(WebCore::updatePathFromPolylineElement):

LayoutTests:

New tests covering the actual application of the animated value
for the "points" attribute of the SVG <polygon> and <polyline> elements.

* svg/animations/polygon-set-expected.svg: Added.
* svg/animations/polygon-set.svg: Added.
* svg/animations/polyline-set-expected.svg: Added.
* svg/animations/polyline-set.svg: Added.


Canonical link: https://commits.webkit.org/142816@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog

@@ -1,3 +1,18 @@
+2013-11-20  Antoine Quint  <graouts@apple.com>
+
+        Cannot animate "points" attribute for <svg:polygon>
+        https://bugs.webkit.org/show_bug.cgi?id=21371
+
+        Reviewed by Antti Koivisto.
+
+        New tests covering the actual application of the animated value
+        for the "points" attribute of the SVG <polygon> and <polyline> elements.
+
+        * svg/animations/polygon-set-expected.svg: Added.
+        * svg/animations/polygon-set.svg: Added.
+        * svg/animations/polyline-set-expected.svg: Added.
+        * svg/animations/polyline-set.svg: Added.
+
 2013-11-20  Zan Dobersek  <zdobersek@igalia.com>
 
         Configurability test of prototype's properties in fast/dom/webidl-operations-on-node-prototype.html is wrong

Source/WebCore/ChangeLog

@@ -1,3 +1,21 @@
+2013-11-20  Antoine Quint  <graouts@apple.com>
+
+        Cannot animate "points" attribute for <svg:polygon>
+        https://bugs.webkit.org/show_bug.cgi?id=21371
+
+        Reviewed by Antti Koivisto.
+
+        Ensure we use animated list of points for SVG <polygon> and <polyline> elements
+        when we build the path used to draw them, otherwise the animated changes won't
+        be rendered and the base value will be used.
+
+        Tests: svg/animations/polygon-set.svg
+               svg/animations/polyline-set.svg
+
+        * rendering/svg/SVGPathData.cpp:
+        (WebCore::updatePathFromPolygonElement):
+        (WebCore::updatePathFromPolylineElement):
+
 2013-11-20  Andrei Bucur  <abucur@adobe.com>
 
         [CSSRegions] Move region styling code into RenderNamedFlowFragment

Source/WebCore/rendering/svg/SVGPathData.cpp

@@ -76,7 +76,7 @@ static void updatePathFromPathElement(SVGElement* element, Path& path)
 
 static void updatePathFromPolygonElement(SVGElement* element, Path& path)
 {
-    SVGPointList& points = toSVGPolygonElement(element)->pointList();
+    SVGPointList& points = toSVGPolygonElement(element)->animatedPoints()->values();
     if (points.isEmpty())
         return;
 
@@ -91,7 +91,7 @@ static void updatePathFromPolygonElement(SVGElement* element, Path& path)
 
 static void updatePathFromPolylineElement(SVGElement* element, Path& path)
 {
-    SVGPointList& points = toSVGPolylineElement(element)->pointList();
+    SVGPointList& points = toSVGPolylineElement(element)->animatedPoints()->values();
     if (points.isEmpty())
         return;