Skip to content
Permalink
Browse files
REGRESSION(r266844) [ BigSur ] http/tests/security/webaudio-render-re…
…mote-audio-allowed-crossorigin.html is a constant failure

https://bugs.webkit.org/show_bug.cgi?id=216619

Reviewed by Chris Dumez.

Tools:

In r266844, we adopted an API which would cause audio decoding to be supressed when a media element is initially muted. WebKitTestRunner
calls a WebKit SPI to artificially mute all media elements within the page (because listening to LayoutTest beeps and boops is annoying)
which causes this code path to be hit for all media elements. Rather than muting the page, WKTR should do the same as DRT, and set the
output volume to zero.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):

LayoutTests:

* platform/mac-wk2/TestExpectations:


Canonical link: https://commits.webkit.org/229437@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267162 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
jernoble committed Sep 16, 2020
1 parent 5fd2898 commit bbe44cda2d52881f05911132af944c8a4d5119ca
Showing with 25 additions and 4 deletions.
  1. +9 −0 LayoutTests/ChangeLog
  2. +0 −3 LayoutTests/platform/mac-wk2/TestExpectations
  3. +15 −0 Tools/ChangeLog
  4. +1 −1 Tools/WebKitTestRunner/TestController.cpp
@@ -1,3 +1,12 @@
2020-09-16 Jer Noble <jer.noble@apple.com>

REGRESSION(r266844) [ BigSur ] http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=216619

Reviewed by Chris Dumez.

* platform/mac-wk2/TestExpectations:

2020-09-16 Zalan Bujtas <zalan@apple.com>

[LFC][FFC] Add basic flex item sizing and positioning
@@ -1316,9 +1316,6 @@ webkit.org/b/216394 [ Release ] fast/selectors/text-field-selection-stroke-color
# rdar://68740987 (REGRESSION: [ BigSur wk2 ] http/tests/media/video-no-content-length-stall.html is a constant failure)
[ BigSur+ ] http/tests/media/video-no-content-length-stall.html [ Failure ]

# rdar://68743466 (REGRESSION: [ BigSur wk2 ] http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html is a constant failure)
[ BigSur+ ] http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html [ Failure ]

# rdar://68947260 (REGRESSION (r266634): [ BigSur wk2 ] fast/selectors/text-field-selection-window-inactive-stroke-color.html is a flaky image failure)
fast/selectors/text-field-selection-window-inactive-stroke-color.html [ Pass ImageOnlyFailure ]

@@ -1,3 +1,18 @@
2020-09-16 Jer Noble <jer.noble@apple.com>

REGRESSION(r266844) [ BigSur ] http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=216619

Reviewed by Chris Dumez.

In r266844, we adopted an API which would cause audio decoding to be supressed when a media element is initially muted. WebKitTestRunner
calls a WebKit SPI to artificially mute all media elements within the page (because listening to LayoutTest beeps and boops is annoying)
which causes this code path to be hit for all media elements. Rather than muting the page, WKTR should do the same as DRT, and set the
output volume to zero.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):

2020-09-16 Aakash Jain <aakash_jain@apple.com>

[ews] Improve failure summary string for AnalyzeCompileWebKitResults step
@@ -1099,7 +1099,7 @@ bool TestController::resetStateToConsistentValues(const TestOptions& options, Re

WKPageClearWheelEventTestMonitor(m_mainWebView->page());

WKPageSetMuted(m_mainWebView->page(), true);
WKPageSetMediaVolume(m_mainWebView->page(), 0);

WKPageClearUserMediaState(m_mainWebView->page());

0 comments on commit bbe44cd

Please sign in to comment.