Skip to content
Permalink
Browse files
Unreviewed, rolling out r226155.
This caused test failures.

Reverted changeset:

"Web Inspector: add TestPage.debug() to inspect evaluations
being sent to Inspector page"
https://bugs.webkit.org/show_bug.cgi?id=181005
https://trac.webkit.org/changeset/226155

Canonical link: https://commits.webkit.org/196931@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@226207 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
rancored-mongoose committed Dec 21, 2017
1 parent dd5db6d commit bcc56e1ce938566ade83fb1f770d91182c73e709
Showing with 16 additions and 17 deletions.
  1. +13 −0 LayoutTests/ChangeLog
  2. +3 −17 LayoutTests/http/tests/inspector/resources/inspector-test.js
@@ -1,3 +1,16 @@
2017-12-20 Matt Lewis <jlewis3@apple.com>

Unreviewed, rolling out r226155.

This caused test failures.

Reverted changeset:

"Web Inspector: add TestPage.debug() to inspect evaluations
being sent to Inspector page"
https://bugs.webkit.org/show_bug.cgi?id=181005
https://trac.webkit.org/changeset/226155

2017-12-20 Brady Eidson <beidson@apple.com>

Assertion failure in MessagePort::contextDestroyed in http/tests/security/MessagePort/event-listener-context.html, usually attributed to later tests.
@@ -97,8 +97,8 @@ function runTest()
let initializationCodeString = `(${runInitializationMethodsInFrontend.toString()})([${TestPage._initializers}]);`;
let testFunctionCodeString = `(${runTestMethodInFrontend.toString()})(${testFunction.toString()});`;

TestPage.evaluateInWebInspector(initializationCodeString);
TestPage.evaluateInWebInspector(testFunctionCodeString);
testRunner.evaluateInWebInspector(initializationCodeString);
testRunner.evaluateInWebInspector(testFunctionCodeString);
}

function runTestHTTPS()
@@ -139,20 +139,6 @@ TestPage.debugLog = function(message)
window.alert(message);
}

// Use this to dump evaluations that are sent from the TestPage to the InspectorTest page.
TestPage.debug = function()
{
this.dumpInspectorPageEvaluations = true;
}

TestPage.evaluateInWebInspector = function(code)
{
if (this.dumpInspectorPageEvaluations)
this.debugLog(code);

testRunner.evaluateInWebInspector(code);
}

// Add and clear test output from the results window.
TestPage.addResult = function(text)
{
@@ -176,7 +162,7 @@ TestPage.log = TestPage.addResult;
TestPage.dispatchEventToFrontend = function(eventName, data)
{
let dispatchEventCodeString = `InspectorTest.dispatchEventToListeners(${JSON.stringify(eventName)}, ${JSON.stringify(data)});`;
this.evaluateInWebInspector(dispatchEventCodeString);
testRunner.evaluateInWebInspector(dispatchEventCodeString);
};

TestPage.allowUncaughtExceptions = false;

0 comments on commit bcc56e1

Please sign in to comment.