Skip to content
Permalink
Browse files
Crash Log Clobbering on Unbound Crashes
https://bugs.webkit.org/show_bug.cgi?id=160198
<rdar://problem/27472618>

Patch by Jonathan Bedard <jbedard@apple.com> on 2016-07-29
Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs): Fix header order.
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.

Canonical link: https://commits.webkit.org/178490@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@203902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
JonWBedard authored and webkit-commit-queue committed Jul 29, 2016
1 parent 73f92b2 commit bcd0591d2ab3c04ed3cedb1f30c2f4814d47f5de
Showing 4 changed files with 23 additions and 1 deletion.
@@ -272,6 +272,10 @@

function stripExtension(test)
{
// Temporary fix, also in Tools/Scripts/webkitpy/layout_tests/constrollers/test_result_writer.py, line 95.
// FIXME: Refactor to avoid confusing reference to both test and process names.
if (splitExtension(test)[1].length > 5)
return test;
return splitExtension(test)[0];
}

@@ -1,3 +1,16 @@
2016-07-29 Jonathan Bedard <jbedard@apple.com>

Crash Log Clobbering on Unbound Crashes
https://bugs.webkit.org/show_bug.cgi?id=160198
<rdar://problem/27472618>

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs): Fix header order.
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.

2016-07-29 Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com>

Update for contributors.json
@@ -28,8 +28,8 @@
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

import codecs
import re
import datetime
import re


class CrashLogs(object):
@@ -89,6 +89,11 @@ def output_filename(self, modifier):
"""
fs = self._filesystem
output_filename = fs.join(self._root_output_dir, self._test_name)

# Temporary fix, also in LayoutTests/fast/harness/results.html, line 275.
# FIXME: Refactor to avoid confusing reference to both test and process names.
if len(fs.splitext(output_filename)[1]) - 1 > 5:
return output_filename + modifier
return fs.splitext(output_filename)[0] + modifier

def _write_binary_file(self, path, contents):

0 comments on commit bcd0591

Please sign in to comment.