Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::…
…resetDefaultsToConsistentValues

https://bugs.webkit.org/show_bug.cgi?id=87668

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-06-04
Reviewed by Ryosuke Niwa.

Tools:

Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might
be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true).

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

LayoutTests:

* platform/efl/Skipped: Unskipped fast/html/tab-order.html.

Canonical link: https://commits.webkit.org/106045@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Mikhail Pozdnyakov authored and webkit-commit-queue committed Jun 4, 2012
1 parent e097841 commit be30d65
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 2 deletions.
9 changes: 9 additions & 0 deletions LayoutTests/ChangeLog
@@ -1,3 +1,12 @@
2012-06-04 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>

[EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
https://bugs.webkit.org/show_bug.cgi?id=87668

Reviewed by Ryosuke Niwa.

* platform/efl/Skipped: Unskipped fast/html/tab-order.html.

2012-05-31 Kinuko Yasuda <kinuko@chromium.org>

[chromium] DataTransferItem.webkitGetAsEntry() should synchronously return entry
Expand Down
1 change: 0 additions & 1 deletion LayoutTests/platform/efl/Skipped
Expand Up @@ -555,7 +555,6 @@ fast/forms/search-transformed.html
fast/forms/search-zoomed.html
fast/forms/range/slider-delete-while-dragging-thumb.html
fast/harness/results.html
fast/html/tab-order.html
fast/repaint/selection-clear.html
fast/repaint/table-cell-overflow.html
fast/repaint/text-emphasis-h.html
Expand Down
14 changes: 14 additions & 0 deletions Tools/ChangeLog
@@ -1,3 +1,17 @@
2012-06-04 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>

[EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
https://bugs.webkit.org/show_bug.cgi?id=87668

Reviewed by Ryosuke Niwa.

Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might
be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true).

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

2012-06-04 Tomasz Morawski <t.morawski@samsung.com>

[EFL] Refactor ewk_view_context_paint code.
Expand Down
2 changes: 1 addition & 1 deletion Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp
Expand Up @@ -240,7 +240,7 @@ void DumpRenderTreeChrome::resetDefaultsToConsistentValues()
ewk_view_setting_minimum_timer_interval_set(browser->mainView(), 0.010); // 10 milliseconds (DOMTimer::s_minDefaultTimerInterval)
ewk_view_setting_enable_webgl_set(mainView(), EINA_TRUE);
ewk_view_setting_enable_hyperlink_auditing_set(mainView(), EINA_FALSE);
ewk_view_setting_include_links_in_focus_chain_set(mainView(), EINA_TRUE);
ewk_view_setting_include_links_in_focus_chain_set(mainView(), EINA_FALSE);
ewk_view_setting_scripts_can_access_clipboard_set(mainView(), EINA_TRUE);

ewk_view_zoom_set(mainView(), 1.0, 0, 0);
Expand Down

0 comments on commit be30d65

Please sign in to comment.