Skip to content
Permalink
Browse files
Drop [UsePointersEvenForNonNullableObjectArguments] from TextTrack
https://bugs.webkit.org/show_bug.cgi?id=156899

Reviewed by Chris Dumez.

No behavior changes.

* html/track/TextTrack.idl: Marking cue and region parameter as nullable.
Also marking cues and activeCues as nullable attributes.


Canonical link: https://commits.webkit.org/175084@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@199986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
youennf committed Apr 25, 2016
1 parent 1d4f507 commit c0e3ff38335eda5af1674521e4ee9ba6889b8a04
Showing with 20 additions and 7 deletions.
  1. +12 −0 Source/WebCore/ChangeLog
  2. +8 −7 Source/WebCore/html/track/TextTrack.idl
@@ -1,3 +1,15 @@
2016-04-25 Youenn Fablet <youenn.fablet@crf.canon.fr>

Drop [UsePointersEvenForNonNullableObjectArguments] from TextTrack
https://bugs.webkit.org/show_bug.cgi?id=156899

Reviewed by Chris Dumez.

No behavior changes.

* html/track/TextTrack.idl: Marking cue and region parameter as nullable.
Also marking cues and activeCues as nullable attributes.

2016-04-25 Youenn Fablet <youenn.fablet@crf.canon.fr>

Drop [UsePointersEvenForNonNullableObjectArguments] from File API interfaces
@@ -28,7 +28,6 @@ enum TextTrackKind { "subtitles", "captions", "descriptions", "chapters", "me

[
Conditional=VIDEO_TRACK,
UsePointersEvenForNonNullableObjectArguments,
GenerateIsReachable=ImplElementRoot,
JSCustomMarkFunction,
SkipVTableValidation,
@@ -41,17 +40,19 @@ enum TextTrackKind { "subtitles", "captions", "descriptions", "chapters", "me

attribute TextTrackMode mode;

readonly attribute TextTrackCueList cues;
readonly attribute TextTrackCueList activeCues;
readonly attribute TextTrackCueList? cues;
readonly attribute TextTrackCueList? activeCues;

[RaisesException] void addCue(TextTrackCue cue);
[RaisesException] void removeCue(TextTrackCue cue);
// FIXME: cue parameter should not be nullable in addCue and removeCue.
[RaisesException] void addCue(TextTrackCue? cue);
[RaisesException] void removeCue(TextTrackCue? cue);

attribute EventHandler oncuechange;

#if !defined(LANGUAGE_GOBJECT) || !LANGUAGE_GOBJECT // Work around shortcomings in the gobject binding generator handling of conditional features by turning these off for gobject.
readonly attribute VTTRegionList regions;
void addRegion(VTTRegion region);
[RaisesException] void removeRegion(VTTRegion region);
// FIXME: region parameter should not be nullable in addRegion and removeRegion.
void addRegion(VTTRegion? region);
[RaisesException] void removeRegion(VTTRegion? region);
#endif
};

0 comments on commit c0e3ff3

Please sign in to comment.