Skip to content
Permalink
Browse files
[ews-build] Buildbot should include builder_display_name in the build…
… events

https://bugs.webkit.org/show_bug.cgi?id=195045

Reviewed by Dewei Zhu.

* BuildSlaveSupport/ews-build/events.py:
(Events.buildStarted): Included builder_display_name in event data. Also renamed
buildername to builder_name to be consistent in naming style.
(Events.buildFinished): Ditto.


Canonical link: https://commits.webkit.org/209478@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242185 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
aj062 committed Feb 28, 2019
1 parent 4b00222 commit c23f34cbcd1533ce8c98e3e957a2aab57ccbaf99
Showing 2 changed files with 22 additions and 2 deletions.
@@ -109,6 +109,9 @@ def buildStarted(self, key, build):
if not build.get('properties'):
build['properties'] = yield self.master.db.builds.getBuildProperties(build.get('buildid'))

builder = yield self.master.db.builders.getBuilder(build.get('builderid'))
builder_display_name = builder.get('description')

data = {
"type": self.type_prefix + "build",
"status": "started",
@@ -120,7 +123,8 @@ def buildStarted(self, key, build):
"started_at": build.get('started_at'),
"complete_at": build.get('complete_at'),
"state_string": build.get('state_string'),
"buildername": self.getBuilderName(build),
"builder_name": self.getBuilderName(build),
"builder_display_name": builder_display_name,
}

self.sendData(data)
@@ -132,6 +136,9 @@ def buildFinished(self, key, build):
if not build.get('steps'):
build['steps'] = yield self.master.db.steps.getSteps(build.get('buildid'))

builder = yield self.master.db.builders.getBuilder(build.get('builderid'))
builder_display_name = builder.get('description')

data = {
"type": self.type_prefix + "build",
"status": "finished",
@@ -143,7 +150,8 @@ def buildFinished(self, key, build):
"started_at": build.get('started_at'),
"complete_at": build.get('complete_at'),
"state_string": build.get('state_string'),
"buildername": self.getBuilderName(build),
"builder_name": self.getBuilderName(build),
"builder_display_name": builder_display_name,
"steps": build.get('steps'),
}

@@ -1,3 +1,15 @@
2019-02-27 Aakash Jain <aakash_jain@apple.com>

[ews-build] Buildbot should include builder_display_name in the build events
https://bugs.webkit.org/show_bug.cgi?id=195045

Reviewed by Dewei Zhu.

* BuildSlaveSupport/ews-build/events.py:
(Events.buildStarted): Included builder_display_name in event data. Also renamed
buildername to builder_name to be consistent in naming style.
(Events.buildFinished): Ditto.

2019-02-27 Chris Dumez <cdumez@apple.com>

Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage

0 comments on commit c23f34c

Please sign in to comment.